Feature/required besu native by garyschulte · Pull Request #8418 · besu-eth/besu

garyschulte · 2025-03-13T23:09:28Z

PR description

Require besu to have certain native library implementations at startup. Fail with an actionable error message if required implementations are not available

This PR also bumps the besu-native dep to 1.2.1, facilitating as broadly as possible the loading of besu-native libraries.

macos aarch64:

...
# OS: osx-aarch_64                                                                                 #
...
2025-03-17 08:12:55.149-07:00 | main | INFO  | Besu | Using the native implementation of alt bn128
2025-03-17 08:12:55.359-07:00 | main | INFO  | Besu | Using the native implementation of modexp
2025-03-17 08:12:55.360-07:00 | main | INFO  | Besu | Using the native implementation of the signature algorithm
2025-03-17 08:12:55.363-07:00 | main | INFO  | Besu | Using the Java implementation of the blake2bf algorithm
...

linux x86_64:

...
# OS: linux-x86_64                                                                                 #
...
2025-03-17 07:28:55.482-07:00 | main | INFO  | Besu | Using the native implementation of alt bn128
2025-03-17 07:28:55.495-07:00 | main | INFO  | Besu | Using the native implementation of modexp
2025-03-17 07:28:55.495-07:00 | main | INFO  | Besu | Using the native implementation of the signature algorithm
2025-03-17 07:28:55.496-07:00 | main | INFO  | Besu | Using the native implementation of the blake2bf algorithm
...

linux aarch64:

...
# OS: linux-aarch_64                                                                               #
...
2025-03-17 08:04:08.473-07:00 | main | INFO  | Besu | Using the native implementation of alt bn128
2025-03-17 08:04:08.502-07:00 | main | INFO  | Besu | Using the native implementation of modexp
2025-03-17 08:04:08.503-07:00 | main | INFO  | Besu | Using the native implementation of the signature algorithm
2025-03-17 08:04:08.507-07:00 | main | INFO  | Besu | Using the Java implementation of the blake2bf algorithm
...

Fixed Issue(s)

#8342

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

spotless: ./gradlew spotlessApply
unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

besu/src/main/java/org/hyperledger/besu/cli/config/NativeRequirement.java

besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java

platform/build.gradle

macfarla

prob also wort a changelog entry

besu/src/main/java/org/hyperledger/besu/cli/config/NativeRequirement.java

besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

Signed-off-by: garyschulte <garyschulte@gmail.com>

review feedback from Sally added secp256k1 requirement Signed-off-by: garyschulte <garyschulte@gmail.com>

Signed-off-by: garyschulte <garyschulte@gmail.com>

…uirements Signed-off-by: garyschulte <garyschulte@gmail.com>

siladu

LGTM

* implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com>

* Feature/required besu native (#8418) * implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix gradle verification (#8435) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * eth_config prototype A prototype for eth_cofig, sharing operational client configuration data via RPC. Signed-off-by: Danno Ferrin <danno@numisight.com> * review comments Signed-off-by: Danno Ferrin <danno@numisight.com> * update precompile names Signed-off-by: Danno Ferrin <danno@numisight.com> * Refactor how next fork is calculated Signed-off-by: Danno Ferrin <danno@numisight.com> * copyright Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

* Feature/required besu native (besu-eth#8418) * implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix gradle verification (besu-eth#8435) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * eth_config prototype A prototype for eth_cofig, sharing operational client configuration data via RPC. Signed-off-by: Danno Ferrin <danno@numisight.com> * review comments Signed-off-by: Danno Ferrin <danno@numisight.com> * update precompile names Signed-off-by: Danno Ferrin <danno@numisight.com> * Refactor how next fork is calculated Signed-off-by: Danno Ferrin <danno@numisight.com> * copyright Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

* Feature/required besu native (besu-eth#8418) * implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix gradle verification (besu-eth#8435) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * eth_config prototype A prototype for eth_cofig, sharing operational client configuration data via RPC. Signed-off-by: Danno Ferrin <danno@numisight.com> * review comments Signed-off-by: Danno Ferrin <danno@numisight.com> * update precompile names Signed-off-by: Danno Ferrin <danno@numisight.com> * Refactor how next fork is calculated Signed-off-by: Danno Ferrin <danno@numisight.com> * copyright Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * formatting Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>

dendees-code

ok now look and see

garyschulte force-pushed the feature/required-besu-native branch from 0af2c7d to bd42bfa Compare March 14, 2025 01:52

macfarla reviewed Mar 14, 2025

View reviewed changes

besu/src/main/java/org/hyperledger/besu/cli/config/NativeRequirement.java Outdated Show resolved Hide resolved

besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java Show resolved Hide resolved

macfarla reviewed Mar 14, 2025

View reviewed changes

platform/build.gradle Outdated Show resolved Hide resolved

garyschulte force-pushed the feature/required-besu-native branch from bd42bfa to 85fa1e0 Compare March 14, 2025 16:03

macfarla approved these changes Mar 17, 2025

View reviewed changes

garyschulte force-pushed the feature/required-besu-native branch 2 times, most recently from d91109f to 923270e Compare March 17, 2025 14:17

garyschulte added 9 commits March 17, 2025 13:48

bump besu-native to 1.2.0

5bdcf9a

Signed-off-by: garyschulte <garyschulte@gmail.com>

implement NativeRequirements for named networks

b4fd8a2

Signed-off-by: garyschulte <garyschulte@gmail.com>

spotless2

c7be0e2

Signed-off-by: garyschulte <garyschulte@gmail.com>

optional ofNullable for NetworkName

594eaca

Signed-off-by: garyschulte <garyschulte@gmail.com>

remove kzg from required libs - rely on separate loading checks

19bdfed

review feedback from Sally added secp256k1 requirement Signed-off-by: garyschulte <garyschulte@gmail.com>

remove unneeded static isLoaded in kzgprecompiledcontract

1d9429b

Signed-off-by: garyschulte <garyschulte@gmail.com>

javadoc

2a02bbe

Signed-off-by: garyschulte <garyschulte@gmail.com>

linting

b41071e

Signed-off-by: garyschulte <garyschulte@gmail.com>

review feedback, bump to 1.3.0 native

d9b333b

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte force-pushed the feature/required-besu-native branch from 923270e to d9b333b Compare March 17, 2025 20:52

garyschulte added 3 commits March 17, 2025 14:27

spotless

1087203

Signed-off-by: garyschulte <garyschulte@gmail.com>

feedback from Simon

2d4e72d

Signed-off-by: garyschulte <garyschulte@gmail.com>

ensure non-named networks are not subject to named network native req…

f8957b8

…uirements Signed-off-by: garyschulte <garyschulte@gmail.com>

siladu approved these changes Mar 17, 2025

View reviewed changes

garyschulte merged commit c924e76 into besu-eth:main Mar 17, 2025
43 checks passed

garyschulte deleted the feature/required-besu-native branch March 17, 2025 23:54

garyschulte added a commit that referenced this pull request Mar 18, 2025

Feature/required besu native (#8418)

ca8fa1c

* implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com>

shemnon pushed a commit to shemnon/besu that referenced this pull request Apr 3, 2025

Feature/required besu native (besu-eth#8418)

d24144b

* implement NativeRequirements for named networks Signed-off-by: garyschulte <garyschulte@gmail.com>

This was referenced Apr 10, 2025

[EPIC] Besu Native libs verification hashgraph/hedera-smart-contracts#1317

Closed

[EPIC] Besu Native libs verification hiero-ledger/hiero-consensus-node#18776

Open

dendees-code reviewed Sep 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/required besu native#8418

Feature/required besu native#8418
garyschulte merged 12 commits intobesu-eth:mainfrom
garyschulte:feature/required-besu-native

garyschulte commented Mar 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macfarla left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siladu left a comment

Uh oh!

Uh oh!

dendees-code left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

garyschulte commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macfarla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siladu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dendees-code left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

garyschulte commented Mar 13, 2025 •

edited

Loading