storage proof key - use 0x0 for zero#8499
Merged
macfarla merged 13 commits intobesu-eth:mainfrom Apr 4, 2025
Merged
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Contributor
Author
|
Note I had to update several I don't think this would be a breaking change - and we'll be now consistent with geth - but flagging for reviewers. |
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
This reverts commit 4d4024e. Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Contributor
Author
|
@lu-pinto based on your feedback and further chat w Gary, adopted your suggestion to keep the leading zeros where we had them before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
return 0x0 for zero key rather than 0x
Added a test for visibility
Fixed Issue(s)
related to #5377
related to rpc-compat hive tests
this fixes 1 hive test:
eth_getProof/get-account-proof-with-storageRefs this comment 5cb6c26#r2017642440
This was discussed on RPC standards call and since odd-length hex strings are widely used we will stick with that. Quantity.create handles the zero edge case already.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests