Disable transaction indexing during initial sync by default#8611
Merged
jframe merged 7 commits intobesu-eth:mainfrom May 23, 2025
Merged
Disable transaction indexing during initial sync by default#8611jframe merged 7 commits intobesu-eth:mainfrom
jframe merged 7 commits intobesu-eth:mainfrom
Conversation
…l option Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe
changed the title
Signed-off-by: Jason Frame <jason.frame@consensys.net>
macfarla
reviewed
May 21, 2025
besu/src/main/java/org/hyperledger/besu/cli/options/SynchronizerOptions.java
Outdated
Show resolved
Hide resolved
…erOptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Jason Frame <jasonwframe@gmail.com>
macfarla
approved these changes
May 22, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
LGTM, made a suggestion about the changelog
macfarla
added
the
doc-change-required
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Jason Frame <jasonwframe@gmail.com>
jframe
changed the title
siladu
approved these changes
May 23, 2025
Contributor
Author
Not sure about performance-rpc. For enterprise the plan was to add it later if needed to the enterprise profile now we have the flag visible. The latest release isn't used by enterprise. |
alexandratran
removed
the
doc-change-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issue(s)
Follow up on #8181 to disable transaction indexing during sync by default.
This also promotes this to a non-experimental CLI option so that users that need to disable this are more easily able to do so.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests