Skip to content

Remove gas calculator cost methods deprecated since 24.4#8817

Merged
macfarla merged 7 commits intobesu-eth:mainfrom
macfarla:rm-deprecated-gas-calc-methods
Jun 19, 2025
Merged

Remove gas calculator cost methods deprecated since 24.4#8817
macfarla merged 7 commits intobesu-eth:mainfrom
macfarla:rm-deprecated-gas-calc-methods

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

  • Remove methods from GasCalculator deprecated since 24.2: create2OperationGasCost, callOperationGasCost, createOperationGasCost, and cost

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla added 6 commits June 13, 2025 10:24
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla changed the title Remove gas calculator cost methods deprecated since 24.2 Remove gas calculator cost methods deprecated since 24.4 Jun 13, 2025
@macfarla macfarla added the techdebt maintenance, cleanup, refactoring, documentation label Jun 13, 2025
@macfarla macfarla enabled auto-merge (squash) June 19, 2025 06:43
@macfarla macfarla merged commit e2a799b into besu-eth:main Jun 19, 2025
48 checks passed
@macfarla macfarla deleted the rm-deprecated-gas-calc-methods branch June 26, 2025 03:27
@jflo jflo added this to Maintenance Nov 18, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Maintenance Nov 18, 2025
@jflo jflo removed this from Maintenance Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

techdebt maintenance, cleanup, refactoring, documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants