Expose methods to query the hardfork in the Plugin API#8909
Merged
fab-10 merged 2 commits intobesu-eth:mainfrom Jul 11, 2025
Merged
Expose methods to query the hardfork in the Plugin API#8909fab-10 merged 2 commits intobesu-eth:mainfrom
fab-10 merged 2 commits intobesu-eth:mainfrom
Conversation
fab-10
force-pushed
the
expose-hardfork-in-plugin-api
branch
5 times, most recently
from
a404b8d to
aa82ffd
Compare
fab-10
force-pushed
the
expose-hardfork-in-plugin-api
branch
from
aa82ffd to
7a25de3
Compare
macfarla
reviewed
Jul 8, 2025
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ProtocolSpec.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ProtocolSchedule.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/BlockHeaderBuilder.java
Show resolved
Hide resolved
fab-10
force-pushed
the
expose-hardfork-in-plugin-api
branch
from
7a25de3 to
cf02a1f
Compare
macfarla
approved these changes
Jul 9, 2025
siladu
reviewed
Jul 10, 2025
| .put("gasUsed", "0x" + Long.toHexString(evmGas)) | ||
| .put("pass", initialMessageFrame.getExceptionalHaltReason().isEmpty()) | ||
| .put("fork", protocolSpec.getName()); | ||
| .put("fork", protocolSpec.getHardforkId().description()); |
Contributor
There was a problem hiding this comment.
Is this String identical to the former getName() or a potential breaking change?
Contributor
Author
There was a problem hiding this comment.
yes, I changed the description of the HardforkId enum where needed to match the string returned by the name method
fab-10
force-pushed
the
expose-hardfork-in-plugin-api
branch
2 times, most recently
from
3c73327 to
7974bb6
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
expose-hardfork-in-plugin-api
branch
from
7974bb6 to
fe19dbb
Compare
9 tasks
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Sep 8, 2025
* Expose methods to query the hardfork in the Plugin API Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Add acceptance test Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Sep 8, 2025
* Expose methods to query the hardfork in the Plugin API Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Add acceptance test Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Expose 2 new method in the Plugin API to let plugins query hardfork by blockheader or the hardfork of the next build block.
Since the
HardforkIdwas already part of the Plugin API, it is now used internally when creating the milestone schedule in place of raw string names.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests