Skip to content

remove PoW specific RPCs#9481

Merged
macfarla merged 5 commits intobesu-eth:mainfrom
macfarla:remove-pow-rpc-methods
Nov 21, 2025
Merged

remove PoW specific RPCs#9481
macfarla merged 5 commits intobesu-eth:mainfrom
macfarla:remove-pow-rpc-methods

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented Nov 21, 2025 •
edited
Loading

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

Remove PoW specific RPCs: eth_getMinerDataByBlockHash, eth_getMinerDataByBlockNumber, miner_setCoinbase, miner_setEtherbase
Keeping miner_start/stop and eth_mining since they can be useful for clique.

Fixed Issue(s)

Ref #9455

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@macfarla
remove PoW specific RPCs
f53496d 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
update test to use a non-deleted RPC
1da704f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
update test to use a non-deleted RPC
a9dcc74 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copilot AI review requested due to automatic review settings November 21, 2025 03:48
@macfarla
changelog
447615a 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 21, 2025
@macfarla
Copy link
Copy Markdown
Contributor Author

macfarla commented Nov 21, 2025

docs that need to be updated (RPC methods removed)
https://besu.hyperledger.org/public-networks/reference/api#eth_getminerdatabyblockhash-deprecated
https://besu.hyperledger.org/public-networks/reference/api#eth_getminerdatabyblocknumber
https://besu.hyperledger.org/public-networks/reference/api#miner_setcoinbase

@macfarla
formatting
5c2ec72 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added the breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. label Nov 21, 2025
Copilot AI reviewed Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

jframe
jframe approved these changes Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to remove these

@macfarla macfarla merged commit 5d9dc0f into besu-eth:main Nov 21, 2025
46 checks passed
@macfarla macfarla deleted the remove-pow-rpc-methods branch November 21, 2025 07:04
@macfarla macfarla mentioned this pull request Nov 25, 2025
Open
42 tasks
@bgravenorst bgravenorst mentioned this pull request Nov 25, 2025
Closed
@bgravenorst bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 25, 2025
@m4sterbunny m4sterbunny mentioned this pull request Nov 28, 2025
Merged
pinges pushed a commit to pinges/besu that referenced this pull request Dec 15, 2025
@macfarla @pinges
remove PoW specific RPCs (besu-eth#9481)
7577aef 
* remove PoW specific RPCs

* update test to use a non-deleted RPC

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jframe jframe jframe approved these changes

Assignees

No one assigned

Labels

breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@macfarla @jframe @bgravenorst