remove PoW CLI options --miner-enabled and --miner-coinbase#9486
Merged
macfarla merged 6 commits intobesu-eth:mainfrom Nov 25, 2025
Merged
remove PoW CLI options --miner-enabled and --miner-coinbase#9486macfarla merged 6 commits intobesu-eth:mainfrom
macfarla merged 6 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
macfarla
added
doc-change-required
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
10 tasks
jframe
previously approved these changes
Nov 24, 2025
jframe
approved these changes
Nov 25, 2025
42 tasks
bgravenorst
removed
the
doc-change-required
10 tasks
pinges
pushed a commit
to pinges/besu
that referenced
this pull request
Dec 15, 2025
…#9486) * remove PoW --miner-enabled and --miner-coinbase Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Removing PoW specific CLI options:
Note that Clique uses coinbase and miner-enabled, but they are not user-configured, rather Clique sets them to the local node address (see CliqueMinerExecutor) and true (CliqueBesuControllerBuilder) - will refactor that in a separate PR.
So for all intents and purposes, have removed
--miner-enabledand--miner-coinbasealthough they remain as hidden options with no effect.Removed dependency checking between
--miner-enabledand other optionsAlso removed
checkMultiOptionDependenciesfunctionality since this was not used in production code.Fixed Issue(s)
Refs #9454
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests