Skip to content

Remove EOF#9559

Merged
daniellehrner merged 10 commits intobesu-eth:mainfrom
daniellehrner:remove_eof
Dec 16, 2025
Merged

Remove EOF#9559
daniellehrner merged 10 commits intobesu-eth:mainfrom
daniellehrner:remove_eof

Conversation

@daniellehrner
Copy link
Copy Markdown
Contributor

@daniellehrner daniellehrner commented Dec 10, 2025

PR description

When I started to work on EIP-8024 (SWAPN, DUPN, EXCHANGE) for Amsterdam, I realised that this EIP is incompatible with the EOF version of SWAPN, DUPN, EXCHANGE. As we break EOF anyways, I thought it’s best to remove EOF completely as it seems it not going into mainnet ever. It’s a huge PR with more than 11k LOCs removed, most of it is just deleting EOF specific files, but there are also many changes in mainnet relevant files. So the review should be done carefully to make sure I did not break anything else by accident.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner marked this pull request as ready for review December 12, 2025 10:05
Copilot AI review requested due to automatic review settings December 12, 2025 10:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner enabled auto-merge (squash) December 16, 2025 08:58
@daniellehrner daniellehrner merged commit cd1fb99 into besu-eth:main Dec 16, 2025
59 of 61 checks passed
@daniellehrner daniellehrner deleted the remove_eof branch December 16, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants