Merged
Conversation
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…su plugin Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
# Conflicts: # acceptance-tests/catalogless-test-plugins/build.gradle # acceptance-tests/tests/build.gradle # acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/plugins/PluginConfigurationReloadTest.java # app/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java # ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/PluginsReloadConfiguration.java # settings.gradle
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
ad0d04f to
d89adfd
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
6ecf85b to
f23957b
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
e1e9230 to
c758f59
Compare
usmansaleem
reviewed
Jan 21, 2026
acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/node/BesuNode.java
Show resolved
Hide resolved
usmansaleem
reviewed
Jan 21, 2026
app/src/main/java/org/hyperledger/besu/services/PluginVerifier.java
Outdated
Show resolved
Hide resolved
usmansaleem
approved these changes
Jan 21, 2026
Contributor
usmansaleem
left a comment
There was a problem hiding this comment.
LGTM, very minor nit-pick that can be ignored.
6 tasks
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
macfarla
pushed a commit
to CPerezz/besu
that referenced
this pull request
Feb 6, 2026
* Verify plugins before registration Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Add comprehensive plugin verification on startup
This PR introduces plugin verification checks that run before plugin registration to ensure compatibility and prevent runtime conflicts. The verification includes:
The verification behavior is configurable via the new option
plugins-verification-mode, that could take the values:NONE(default): log at WARN any issue found during the verification phase, but does not prevent the start of BesuFULL: log at ERROR and prevent Besu from starting in case of any issue found during the verification.More fine grained options could to come later if needed, to further customize the verification phase
The core of the feature is implemented in these classes:
PluginVerifierBesuPluginContextImplthe rest of the PR consists mainly in the extensions of the tests to cover all the different scenarios
Fixed Issue(s)
fixes #8551
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests