Skip to content

Add byte-level metrics for P2P message exchange#9666

Merged
fab-10 merged 1 commit intobesu-eth:mainfrom
fab-10:add-metrics-for-bytes-exchanged-via-p2p
Feb 10, 2026
Merged

Add byte-level metrics for P2P message exchange#9666
fab-10 merged 1 commit intobesu-eth:mainfrom
fab-10:add-metrics-for-bytes-exchanged-via-p2p

Conversation

@fab-10
Copy link
Copy Markdown
Contributor

@fab-10 fab-10 commented Jan 21, 2026

PR description

Built on top of #9680, please review it first.

Introduce besu_network_p2p_bytes_inbound and besu_network_p2p_bytes_outbound metrics to track
the number of bytes exchanged via P2P connections, providing better
visibility into network bandwidth usage alongside existing message counts.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Copilot AI review requested due to automatic review settings January 21, 2026 17:10
@macfarla macfarla moved this to Open PRs in 26.1.0 Release Jan 22, 2026
@fab-10 fab-10 force-pushed the add-metrics-for-bytes-exchanged-via-p2p branch 6 times, most recently from 3182495 to ce9c093 Compare January 27, 2026 11:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fab-10 any performance impact from this?

@fab-10
Copy link
Copy Markdown
Contributor Author

fab-10 commented Feb 10, 2026

@fab-10 any performance impact from this?

I have seen none

@fab-10 fab-10 force-pushed the add-metrics-for-bytes-exchanged-via-p2p branch from ce9c093 to c581f2c Compare February 10, 2026 09:49
@fab-10 fab-10 enabled auto-merge (squash) February 10, 2026 09:49
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the add-metrics-for-bytes-exchanged-via-p2p branch from c581f2c to d939994 Compare February 10, 2026 09:50
@fab-10 fab-10 merged commit 6b1614c into besu-eth:main Feb 10, 2026
46 checks passed
@fab-10 fab-10 deleted the add-metrics-for-bytes-exchanged-via-p2p branch February 10, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants