feat: implement convenient path methods + add iteration key (#1091)

* feat: implement convenient path methods + add iterateConsensusState key

* imp: just keeping iteration key func

* nitpicking

Author: Farhad-Shabani

.changelog/unreleased/feature/1090-add-iterate-consensus-states-key.md

@@ -0,0 +1,3 @@
+- [ibc-core-host] Add iteration key for cross-compatibility with `ibc-go` used
+  for iterating over consensus states
+  ([\#1090](https://github.com/cosmos/ibc-rs/issues/1090))

.changelog/unreleased/improvements/1089-implement-convenient-path-methods.md

@@ -0,0 +1,3 @@
+- [ibc-core-host] Improve path segment access by exposing path prefixes and
+  implementing some convenient parent/leaf methods
+  ([\#1089](https://github.com/cosmos/ibc-rs/issues/1089))

ibc-clients/ics07-tendermint/src/client_state.rs

@@ -328,7 +328,7 @@ where
 
         let tm_consensus_state = TmConsensusState::try_from(consensus_state)?;
 
-        ctx.store_client_state(ClientStatePath::new(client_id), self.clone().into())?;
+        ctx.store_client_state(ClientStatePath::new(client_id.clone()), self.clone().into())?;
         ctx.store_consensus_state(
             ClientConsensusStatePath::new(
                 client_id.clone(),
@@ -389,7 +389,7 @@ where
                 TmConsensusState::from(new_consensus_state).into(),
             )?;
             ctx.store_client_state(
-                ClientStatePath::new(client_id),
+                ClientStatePath::new(client_id.clone()),
                 ClientState::from(new_client_state).into(),
             )?;
             ctx.store_update_meta(
@@ -419,7 +419,7 @@ where
         let wrapped_frozen_client_state = ClientState::from(frozen_client_state);
 
         ctx.store_client_state(
-            ClientStatePath::new(client_id),
+            ClientStatePath::new(client_id.clone()),
             wrapped_frozen_client_state.into(),
         )?;
 
@@ -480,7 +480,7 @@ where
         let host_height = CommonContext::host_height(ctx)?;
 
         ctx.store_client_state(
-            ClientStatePath::new(client_id),
+            ClientStatePath::new(client_id.clone()),
             ClientState::from(new_client_state).into(),
         )?;
         ctx.store_consensus_state(

ibc-core/ics03-connection/src/handler/conn_open_ack.rs

@@ -100,7 +100,7 @@ where
                 prefix_on_b,
                 &msg.proof_client_state_of_a_on_b,
                 consensus_state_of_b_on_a.root(),
-                Path::ClientState(ClientStatePath::new(vars.client_id_on_b())),
+                Path::ClientState(ClientStatePath::new(vars.client_id_on_b().clone())),
                 msg.client_state_of_a_on_b.to_vec(),
             )
             .map_err(|e| ConnectionError::ClientStateVerificationFailure {

ibc-core/ics03-connection/src/handler/conn_open_init.rs

@@ -74,7 +74,7 @@ where
 
     ctx_a.increase_connection_counter()?;
     ctx_a.store_connection_to_client(
-        &ClientConnectionPath::new(&msg.client_id_on_a),
+        &ClientConnectionPath::new(msg.client_id_on_a),
         conn_id_on_a.clone(),
     )?;
     ctx_a.store_connection(&ConnectionPath::new(&conn_id_on_a), conn_end_on_a)?;

ibc-core/ics03-connection/src/handler/conn_open_try.rs

@@ -95,7 +95,7 @@ where
                 prefix_on_a,
                 &msg.proof_client_state_of_b_on_a,
                 consensus_state_of_a_on_b.root(),
-                Path::ClientState(ClientStatePath::new(client_id_on_a)),
+                Path::ClientState(ClientStatePath::new(client_id_on_a.clone())),
                 msg.client_state_of_b_on_a.to_vec(),
             )
             .map_err(|e| ConnectionError::ClientStateVerificationFailure {
@@ -162,7 +162,7 @@ where
 
     ctx_b.increase_connection_counter()?;
     ctx_b.store_connection_to_client(
-        &ClientConnectionPath::new(&msg.client_id_on_b),
+        &ClientConnectionPath::new(msg.client_id_on_b),
         vars.conn_id_on_b.clone(),
     )?;
     ctx_b.store_connection(&ConnectionPath::new(&vars.conn_id_on_b), vars.conn_end_on_b)?;