WIP - focus test on messaging, grant perms out-of-band, record video of test

Author: mikehardy

.github/workflows/tests_e2e_ios.yml

@@ -171,6 +171,11 @@ jobs:
           curl --output /dev/null --silent --head --fail "http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&inlineSourceMap=true"
           echo "...javascript bundle ready"
 
+      - name: Record App Video
+        # With a little delay so the detox test below has time to spawn it, missing the first part of boot is fine
+        continue-on-error: true
+        run: nohup sh -c "sleep 30 && xcrun simctl io booted recordVideo --codec=h264 -f simulator.mp4 2>&1 &"
+
       - name: Create Simulator Log
         # With a little delay so the detox test below has time to spawn it, missing the first part of boot is fine
         # If you boot the simulator separately from detox, some other race fails and detox testee never sends ready to proxy
@@ -179,7 +184,22 @@ jobs:
 
       - name: Detox Test
         timeout-minutes: 50
-        run: yarn tests:ios:test-cover
+        # The ps command will just give us a hint on what Simulator is running
+        run: |
+          ps -ef | grep -i backboard
+          yarn tests:ios:test-cover
+
+      - name: Stop App Video
+        if: always()
+        run: killall -INT simctl
+
+      - name: Upload App Video
+        uses: actions/upload-artifact@v4
+        continue-on-error: true
+        if: always()
+        with:
+          name: simulator_video
+          path: simulator.mp4
 
       - name: Upload Simulator Log
         uses: actions/upload-artifact@v4

packages/messaging/e2e/messaging.e2e.js

@@ -39,12 +39,13 @@ async function isAPNSCapableSimulator() {
 describe('messaging()', function () {
   before(async function () {
     // our device registration tests require permissions. Set them up
-    await firebase.messaging().requestPermission({
+    const perms = await firebase.messaging().requestPermission({
       alert: true,
       badge: true,
       sound: true,
       provisional: true,
     });
+    console.warn('requestPermission got perms ' + perms);
   });
 
   describe('firebase v8 compatibility', function () {
@@ -133,8 +134,12 @@ describe('messaging()', function () {
           // our default resolve on android is "authorized"
           should.equal(await firebase.messaging().requestPermission({ provisional: true }), 1);
         } else {
-          // our default request on iOS results in "provisional"
-          should.equal(await firebase.messaging().requestPermission({ provisional: true }), 2);
+          // our default request on iOS results in "provisional" == 2
+          // but we may have granted perms by any outside method == 1
+          should.equal(
+            (await firebase.messaging().requestPermission({ provisional: true })) >= 1,
+            true,
+          );
         }
       });
     });
@@ -601,8 +606,9 @@ describe('messaging()', function () {
         if (device.getPlatform() === 'android') {
           should.equal(await requestPermission(getMessaging()), 1);
         } else {
-          // ... and iOS should always be 2 (provisional)
-          should.equal(await requestPermission(getMessaging(), { provisional: true }), 2);
+          // our default request on iOS results in "provisional" == 2
+          // but we may have granted perms by any outside method == 1
+          should.equal((await requestPermission(getMessaging(), { provisional: true })) >= 1, true);
         }
       });
     });

tests/e2e/.mocharc.js

@@ -10,22 +10,22 @@ module.exports = {
   exit: true,
   require: 'node_modules/jet/platform/node',
   spec: [
-    '../packages/app/e2e/**/*.e2e.js',
-    '../packages/app-check/e2e/**/*.e2e.js',
-    '../packages/app-distribution/e2e/**/*.e2e.js',
-    '../packages/analytics/e2e/**/*.e2e.js',
-    '../packages/auth/e2e/**/*.e2e.js',
-    '../packages/crashlytics/e2e/**/*.e2e.js',
-    '../packages/database/e2e/**/*.e2e.js',
-    '../packages/dynamic-links/e2e/**/*.e2e.js',
-    '../packages/firestore/e2e/**/*.e2e.js',
-    '../packages/functions/e2e/**/*.e2e.js',
-    '../packages/perf/e2e/**/*.e2e.js',
+    // '../packages/app/e2e/**/*.e2e.js',
+    // '../packages/app-check/e2e/**/*.e2e.js',
+    // '../packages/app-distribution/e2e/**/*.e2e.js',
+    // '../packages/analytics/e2e/**/*.e2e.js',
+    // '../packages/auth/e2e/**/*.e2e.js',
+    // '../packages/crashlytics/e2e/**/*.e2e.js',
+    // '../packages/database/e2e/**/*.e2e.js',
+    // '../packages/dynamic-links/e2e/**/*.e2e.js',
+    // '../packages/firestore/e2e/**/*.e2e.js',
+    // '../packages/functions/e2e/**/*.e2e.js',
+    // '../packages/perf/e2e/**/*.e2e.js',
     '../packages/messaging/e2e/**/*.e2e.js',
-    '../packages/ml/e2e/**/*.e2e.js',
-    '../packages/in-app-messaging/e2e/**/*.e2e.js',
-    '../packages/installations/e2e/**/*.e2e.js',
-    '../packages/remote-config/e2e/**/*.e2e.js',
-    '../packages/storage/e2e/**/*.e2e.js',
+    // '../packages/ml/e2e/**/*.e2e.js',
+    // '../packages/in-app-messaging/e2e/**/*.e2e.js',
+    // '../packages/installations/e2e/**/*.e2e.js',
+    // '../packages/remote-config/e2e/**/*.e2e.js',
+    // '../packages/storage/e2e/**/*.e2e.js',
   ],
 };

tests/e2e/init.js

@@ -29,6 +29,13 @@ config.configurations['android.emu.debug'].device.avdName =
 before(async function () {
   await detox.init(config);
   await device.launchApp();
+
+  // our messaging tests require notification permission now
+  execSync(
+    `applesimutils --booted --setPermissions notifications=YES --bundle io.invertase.testing`,
+  );
+  // after setting perms you have to launch the app again
+  await device.launchApp();
   await jet.init();
 });