Skip to content

feat: Update dependencies#12

Merged
coreyfarrell merged 2 commits intoistanbuljs:masterfrom
coreyfarrell:node8
Sep 9, 2019
Merged

feat: Update dependencies#12
coreyfarrell merged 2 commits intoistanbuljs:masterfrom
coreyfarrell:node8

Conversation

@coreyfarrell
Copy link
Copy Markdown
Member

@coreyfarrell coreyfarrell commented Sep 7, 2019

BREAKING CHANGE: Requires Node.js 8


I've posted a PR to default-require-extensions to update to the latest strip-bom which requires node.js 8. My plan is to hold off on a new append-transform release until an updated release of default-require-extensions is made (I'll probably just amend this commit).

Technically none of the production code actually requires node.js 8 but all of the testing does, so we're just being clear about what is supported. This does actually break Node.js < 6 due to use of default arguments.

BREAKING CHANGE: Requires Node.js 8
Copy link
Copy Markdown
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change - but mostly 👍

Comment thread index.js Outdated
@JaKXz JaKXz self-requested a review September 9, 2019 19:27
@coreyfarrell coreyfarrell merged commit 2a8b22b into istanbuljs:master Sep 9, 2019
@coreyfarrell coreyfarrell deleted the node8 branch September 9, 2019 22:37
@coreyfarrell
Copy link
Copy Markdown
Member Author

I don't have publish rights for this package on npm, I didn't realize this until after I generated the new release commit / tag and pushed to github.

@JaKXz
Copy link
Copy Markdown
Contributor

JaKXz commented Sep 10, 2019

@coreyfarrell just published + append-transform@2.0.0 for you - I don't know how to add a collaborator on the npm website atm 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants