Skip to content

fix: space in shebang path for windows #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pangrr wants to merge 1 commit into from
Closed

fix: space in shebang path for windows #70

pangrr wants to merge 1 commit into from

Conversation

@pangrr
Copy link

@pangrr pangrr commented Dec 12, 2017 •
edited
Loading

fix #69

@pangrr pangrr mentioned this pull request Dec 12, 2017
Open
@pangrr
Copy link
Author

pangrr commented Dec 12, 2017 •
edited
Loading

Test failed on node 6 + linux.
I don't think this change affects linux.
Any idea?

@gucong3000
Copy link

gucong3000 commented Feb 6, 2018

Test failed on node 6 + linux.

Can someone help restart this job?

@gucong3000
Copy link

gucong3000 commented Mar 2, 2018

I have used this patch in my project for some time and it works fine.

@pangrr
Copy link
Author

pangrr commented Mar 9, 2018

@isaacs ?

@gucong3000 gucong3000 mentioned this pull request Mar 12, 2018
Closed
@pangrr pangrr mentioned this pull request Mar 29, 2018
Closed
@gucong3000
Copy link

gucong3000 commented Apr 4, 2018

Is there anything I can do to help this PR merge?

@gucong3000
Copy link

gucong3000 commented May 7, 2018

@sindresorhus ?

@demurgos
Copy link
Contributor

demurgos commented Aug 13, 2018 •
edited
Loading

Hi,
I'm currently working on the lib: I'll try to merge your changes. It would be nice to have Appveyor failing due to the bug.

@gucong3000
Copy link

gucong3000 commented Sep 30, 2018 

C:\Users\cdyf\.node-spawn-wrap-7052-a076e96a7dcd
$ "C:\Program Files\Git\bin\bash.exe"

cdyf@cdyf-fe-qil MINGW64 ~/.node-spawn-wrap-7052-a076e96a7dcd
$ cat test.sh
#!C:\Program Files\Git\bin\bash.exe
echo hello
cdyf@cdyf-fe-qil MINGW64 ~/.node-spawn-wrap-7052-a076e96a7dcd
$ ./test.sh
bash: ./test.sh: C:\Program: bad interpreter: No such file or directory

cdyf@cdyf-fe-qil MINGW64 ~/.node-spawn-wrap-7052-a076e96a7dcd
$ cat test-env.sh
#!/bin/env C:\Program Files\Git\bin\bash.exe
echo hello
cdyf@cdyf-fe-qil MINGW64 ~/.node-spawn-wrap-7052-a076e96a7dcd
$ ./test-env.sh
hello

@gucong3000 gucong3000 mentioned this pull request Sep 30, 2018
Open
@isaacs isaacs deleted the branch istanbuljs:master February 26, 2022 20:52
@isaacs isaacs closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Question: run node in shellscript

4 participants

@pangrr @gucong3000 @demurgos @isaacs