fix: https connections and database validation

Author: ivnvxd

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.1] - 2025-06-16
+
+### Fixed
+- **HTTPS Connection**: Fixed SSL/TLS support by using `SafeTransport` for HTTPS URLs instead of regular `Transport`
+- **Database Validation**: Skip database existence check when database is explicitly configured, as listing may be restricted for security
+
 ## [0.1.0] - 2025-06-08
 
 ### Added

mcp_server_odoo/odoo_connection.py

@@ -394,23 +394,24 @@ def auto_select_database(self) -> str:
         Raises:
             OdooConnectionError: If no suitable database can be selected
         """
-        # If database is explicitly configured, validate and use it
+        # If database is explicitly configured, use it without validation
+        # Database listing may be restricted for security reasons
         if self.config.database:
             db_name = self.config.database
             logger.info(f"Using configured database: {db_name}")
-
-            if not self.database_exists(db_name):
-                raise OdooConnectionError(
-                    f"Configured database '{db_name}' does not exist on server"
-                )
-
+            # Skip existence check as database listing might be restricted
             return db_name
 
         # List available databases
         try:
             databases = self.list_databases()
         except Exception as e:
-            raise OdooConnectionError(f"Failed to list databases for auto-selection: {e}") from e
+            # If database listing is restricted, we cannot auto-select
+            logger.warning(f"Cannot list databases (may be restricted): {e}")
+            raise OdooConnectionError(
+                "Database auto-selection failed. Database listing may be restricted. "
+                "Please specify ODOO_DB in your configuration."
+            ) from e
 
         # Handle different scenarios
         if not databases:

mcp_server_odoo/performance.py

@@ -15,7 +15,7 @@
 from dataclasses import dataclass
 from datetime import datetime
 from typing import Any, Dict, List, Optional, Tuple
-from xmlrpc.client import ServerProxy, Transport
+from xmlrpc.client import SafeTransport, ServerProxy, Transport
 
 from .config import OdooConfig
 from .logging_config import get_logger
@@ -271,7 +271,11 @@ def __init__(self, config: OdooConfig, max_connections: int = 10):
         self._connections: List[Tuple[ServerProxy, float]] = []
         self._endpoint_map: List[str] = []  # Track endpoints for each connection
         self._lock = threading.RLock()
-        self._transport = Transport()
+        # Use SafeTransport for HTTPS, regular Transport for HTTP
+        if config.url.startswith("https://"):
+            self._transport = SafeTransport()
+        else:
+            self._transport = Transport()
         self._last_cleanup = time.time()
         self._stats = {
             "connections_created": 0,

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "mcp-server-odoo"
-version = "0.1.0"
+version = "0.1.1"
 description = "A Model Context Protocol server for Odoo ERP systems"
 readme = "README.md"
 requires-python = ">=3.10"

tests/test_database_discovery.py

@@ -113,9 +113,11 @@ def test_auto_select_configured_database(self):
         selected = connection.auto_select_database()
 
         assert selected == "mydb"
+        # list() should not be called when database is configured
+        mock_proxy.list.assert_not_called()
 
     def test_auto_select_configured_database_not_exists(self):
-        """Test auto-selection fails when configured database doesn't exist."""
+        """Test auto-selection uses configured database even if not in list (skip validation)."""
         # Create config with explicit database that doesn't exist
         config = OdooConfig(
             url="http://localhost:8069", api_key="test_api_key", database="nonexistent"
@@ -126,8 +128,11 @@ def test_auto_select_configured_database_not_exists(self):
         mock_proxy.list.return_value = ["db1", "test"]
         connection._db_proxy = mock_proxy
 
-        with pytest.raises(OdooConnectionError, match="does not exist"):
-            connection.auto_select_database()
+        # Should return configured database without validation
+        selected = connection.auto_select_database()
+        assert selected == "nonexistent"
+        # list() should not be called when database is configured
+        mock_proxy.list.assert_not_called()
 
     def test_auto_select_single_database(self, connection):
         """Test auto-selection with single database."""