Skip to content
This repository was archived by the owner on May 18, 2020. It is now read-only.

Commit e19d39b

Browse files
Aergonuspavolloffay
authored andcommitted
Update Jaeger version to 1.5.0 and document used docker tags (#89)
* Jaeger Version++ && Version documentation Similar to #70, addresses #88 Signed-off-by: Victor Lei <KLEI22@bloomberg.net> * Clean up Docker Tag Advice Address PR comments and run CI tests again Signed-off-by: Victor Lei <klei22@bloomberg.net> * (version++)++ Signed-off-by: Victor Lei <klei22@bloomberg.net> * Move image versions to README Signed-off-by: Victor Lei <klei22@bloomberg.net> * Update docker image advice Don't tell people "Feel free to use the latest version" Signed-off-by: Victor Lei <klei22@bloomberg.net>
1 parent 1160529 commit e19d39b

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

README.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
Please see [CONTRIBUTING.md](https://github.com/jaegertracing/jaeger-kubernetes/blob/master/CONTRIBUTING.md)
88

99
## Development setup
10-
This template uses an in-memory storage with a limited functionality for local testing and development.
11-
Do not use this template in production environments.
10+
This template uses an in-memory storage with a limited functionality for local testing and development. The image used defaults to the latest version (released)[https://github.com/jaegertracing/jaeger/releases].
11+
Do not use this template in production environments. Note that functionality may differ from the pinned docker versions for production.
1212

1313
Install everything in the current namespace:
1414
```bash
@@ -21,6 +21,9 @@ can be used instead.
2121

2222
## Production setup
2323

24+
### Pinned Production Version
25+
The docker image tags are manually pinned and manually updated. You should use the current pinned version for production.
26+
2427
### Backing storage
2528

2629
The Jaeger Collector and Query require a backing storage to exist before being started up. As a starting point for your own
@@ -148,6 +151,10 @@ kubectl run jaeger-spark-dependencies --schedule="55 23 * * *" --env="STORAGE=ca
148151

149152
If you want to run the job only once and immediately then remove scheduled flag.
150153

154+
## Deploying Docker Tags
155+
The Jaeger project automatically creates new Docker images with tags that mirror the release number. The production manifests uses pinned versions as to not accidentally break people on new releases.
156+
> A general tip for deploying docker images (i.e. on kubernetes): it's recommended that you do not use the tag `:latest` in production but rather pin the latest version. See the [kubernetes best practices](https://kubernetes.io/docs/concepts/configuration/overview/#container-images) for more details.
157+
151158
## Helm support
152159
A curated [Chart for Kubernetes Helm](https://github.com/kubernetes/charts/tree/master/incubator/jaeger) that adds all components required to run Jaeger.
153160

jaeger-production-template.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ items:
3333
jaeger-infra: collector-pod
3434
spec:
3535
containers:
36-
- image: jaegertracing/jaeger-collector:1.2
36+
- image: jaegertracing/jaeger-collector:1.5.0
3737
name: jaeger-collector
3838
command:
3939
- "/go/bin/collector-linux"
@@ -119,7 +119,7 @@ items:
119119
jaeger-infra: query-pod
120120
spec:
121121
containers:
122-
- image: jaegertracing/jaeger-query:1.2
122+
- image: jaegertracing/jaeger-query:1.5.0
123123
name: jaeger-query
124124
command:
125125
- "/go/bin/query-linux"
@@ -179,7 +179,7 @@ items:
179179
spec:
180180
containers:
181181
- name: agent-instance
182-
image: jaegertracing/jaeger-agent:1.2
182+
image: jaegertracing/jaeger-agent:1.5.0
183183
command:
184184
- "/go/bin/agent-linux"
185185
- "--config-file=/conf/agent.yaml"

production/cassandra.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ items:
120120
spec:
121121
containers:
122122
- name: jaeger-cassandra-schema
123-
image: jaegertracing/jaeger-cassandra-schema:1.2
123+
image: jaegertracing/jaeger-cassandra-schema:1.5.0
124124
env:
125125
- name: MODE
126126
value: "prod"

0 commit comments

Comments
 (0)