Add GA event tracking for actions in trace view by tiffon · Pull Request #191 · jaegertracing/jaeger-ui

tiffon · 2018-03-01T19:02:22Z

Partially addresses #157.

Adds GA event tracking for trace view.

This adds events for:

Viewing time range
Filter set / clear
Open / close
- The trace header
- Parents
- Span details
- Tags, process, logs, log-items in span details
Resize the span-name column

Search and dependency graphs are outstanding and will likely be a different PR.

Signed-off-by: Joe Farro <joef@uber.com>

codecov · 2018-03-01T19:15:12Z

Codecov Report

Merging #191 into master will decrease coverage by 0.06%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   89.15%   89.08%   -0.07%     
==========================================
  Files          98      104       +6     
  Lines        2222     2291      +69     
  Branches      460      466       +6     
==========================================
+ Hits         1981     2041      +60     
- Misses        203      211       +8     
- Partials       38       39       +1

Impacted Files	Coverage Δ
...elineViewer/TimelineHeaderRow/TimelineHeaderRow.js	`100% <ø> (ø)`	⬆️
.../TracePage/TraceTimelineViewer/SpanDetail/index.js	`100% <ø> (ø)`	⬆️
src/index.js	`0% <ø> (ø)`	⬆️
src/components/TracePage/TracePageHeader.js	`80% <ø> (ø)`	⬆️
...aceTimelineViewer/SpanDetail/AccordianKeyValues.js	`100% <ø> (ø)`	⬆️
.../components/TracePage/TraceTimelineViewer/index.js	`50% <ø> (ø)`	⬆️
src/middlewares/index.js	`63.63% <ø> (ø)`	⬆️
src/components/TracePage/KeyboardShortcutsHelp.js	`33.33% <0%> (ø)`	⬆️
src/components/TracePage/index.js	`94.89% <100%> (+0.27%)`	⬆️
src/components/TracePage/SpanGraph/ViewingLayer.js	`92.85% <100%> (ø)`	⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ee282...c9673fd. Read the comment docs.

tiffon · 2018-03-01T19:16:25Z

@simonrobb Can you look this PR over when you get the chance?

Signed-off-by: Joe Farro <joef@uber.com>

simonrobb

Few minor nits.

simonrobb · 2018-03-02T17:05:31Z

src/components/TracePage/KeyboardShortcutsHelp.track.js

+
+const context = 'jaeger/ux/trace/kbd-modal';
+
+export default function trackKbdHelpModal() {


Given you're tracking an event maybe be more verbose with the event being tracked. Suggestion: trackKbdHelpModalOpen

simonrobb · 2018-03-02T17:08:05Z

src/components/TracePage/TracePageHeader.track.js

+const altViewCtx = 'jaeger/ux/trace/alt-view';
+export const slimHeaderCtx = 'jaeger/ux/trace/slim-header';
+
+export function trackAltView() {


Suggestion: trackAltViewOpen

simonrobb · 2018-03-02T17:11:15Z

src/components/TracePage/TracePageHeader.track.js

+  });
+}
+
+export function trackSlimHeader(isOpen: boolean) {


Suggestion: trackSlimHeaderStateChange

simonrobb · 2018-03-02T17:16:37Z

src/index.js

-import JaegerUIApp from './components/App';
-import { context as trackingContext } from './utils/tracking';
-
+// these need to go after the App import


Before or after?

Doh! Merge conflicts... Thanks!

Signed-off-by: Joe Farro <joef@uber.com>

* Track errors in GA w raven-js; TODO: tests, readme Signed-off-by: Joe Farro <joef@uber.com> * Include CSS selector with last error breadcrumb Signed-off-by: Joe Farro <joef@uber.com> * README for GA error tracking Signed-off-by: Joe Farro <joef@uber.com> * Misc cleanup Signed-off-by: Joe Farro <joef@uber.com> * README info on GA Application Tracking Signed-off-by: Joe Farro <joef@uber.com> * Misc fix to tracking README Signed-off-by: Joe Farro <joef@uber.com> * Misc cleanup to raven message conversion to GA Signed-off-by: Joe Farro <joef@uber.com> * Tests for tracking Signed-off-by: Joe Farro <joef@uber.com> * Apply prettier to markdown files Signed-off-by: Joe Farro <joef@uber.com> * Error tracking fn name fallback, CSS import order Signed-off-by: Joe Farro <joef@uber.com> * GA event tracking in trace view, tests are TODO Signed-off-by: Joe Farro <joef@uber.com> * Fix broken tests Signed-off-by: Joe Farro <joef@uber.com> * Tests for TracePage tracking Signed-off-by: Joe Farro <joef@uber.com> * Additional tests for trace GA event tracking Signed-off-by: Joe Farro <joef@uber.com> * Better names for tracking functions Signed-off-by: Joe Farro <joef@uber.com> * Make GA event tracking more concise (PR feedback) Signed-off-by: Joe Farro <joef@uber.com> * Revert the "more concise" changes Signed-off-by: Joe Farro <joef@uber.com> * Update changelog Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

tiffon added 15 commits February 10, 2018 08:02

Track errors in GA w raven-js; TODO: tests, readme

0c9ff94

Signed-off-by: Joe Farro <joef@uber.com>

Include CSS selector with last error breadcrumb

2321117

Signed-off-by: Joe Farro <joef@uber.com>

README for GA error tracking

45e93aa

Signed-off-by: Joe Farro <joef@uber.com>

Misc cleanup

11d2f03

Signed-off-by: Joe Farro <joef@uber.com>

README info on GA Application Tracking

1f11a8f

Signed-off-by: Joe Farro <joef@uber.com>

Misc fix to tracking README

d6bb7e2

Signed-off-by: Joe Farro <joef@uber.com>

Merge branch 'master' into issue-157-enhanced-ga

a99db35

Misc cleanup to raven message conversion to GA

b1a94a7

Signed-off-by: Joe Farro <joef@uber.com>

Tests for tracking

8a90112

Signed-off-by: Joe Farro <joef@uber.com>

Apply prettier to markdown files

22a7ac0

Signed-off-by: Joe Farro <joef@uber.com>

Error tracking fn name fallback, CSS import order

263c8ae

Signed-off-by: Joe Farro <joef@uber.com>

GA event tracking in trace view, tests are TODO

dfd9abb

Signed-off-by: Joe Farro <joef@uber.com>

Merge branch 'master' into issue-157-enhanced-ga

0d4e6dd

Fix broken tests

6132dd4

Signed-off-by: Joe Farro <joef@uber.com>

Tests for TracePage tracking

7b1cd7a

Signed-off-by: Joe Farro <joef@uber.com>

tiffon requested review from saminzadeh and yurishkuro March 1, 2018 19:02

ghost assigned tiffon Mar 1, 2018

ghost added the review label Mar 1, 2018

Additional tests for trace GA event tracking

ce467f4

Signed-off-by: Joe Farro <joef@uber.com>

simonrobb approved these changes Mar 2, 2018

View reviewed changes

tiffon added 3 commits March 6, 2018 10:08

Better names for tracking functions

d749767

Signed-off-by: Joe Farro <joef@uber.com>

Make GA event tracking more concise (PR feedback)

b3ea6fb

Signed-off-by: Joe Farro <joef@uber.com>

Revert the "more concise" changes

c60b135

Signed-off-by: Joe Farro <joef@uber.com>

simonrobb approved these changes Mar 23, 2018

View reviewed changes

yurishkuro approved these changes Mar 23, 2018

View reviewed changes

tiffon added 2 commits March 26, 2018 13:37

Merge branch 'master' into issue-157-enhanced-ga

bef6aee

Signed-off-by: Joe Farro <joef@uber.com>

Update changelog

c9673fd

Signed-off-by: Joe Farro <joef@uber.com>

tiffon merged commit c622330 into master Mar 26, 2018

ghost removed the review label Mar 26, 2018

yurishkuro deleted the issue-157-enhanced-ga branch January 29, 2020 15:07

snyk-bot mentioned this pull request Jul 6, 2021

[Snyk] Security upgrade d3-zoom from 1.8.3 to 3.0.0 m3ntalsp00n/jaeger-ui#7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GA event tracking for actions in trace view#191

Add GA event tracking for actions in trace view#191
tiffon merged 21 commits intomasterfrom
issue-157-enhanced-ga

tiffon commented Mar 1, 2018 •

edited

Loading

Uh oh!

codecov bot commented Mar 1, 2018 •

edited

Loading

Uh oh!

tiffon commented Mar 1, 2018

Uh oh!

simonrobb left a comment

Uh oh!

simonrobb Mar 2, 2018

Uh oh!

tiffon Mar 6, 2018

Uh oh!

simonrobb Mar 2, 2018

Uh oh!

tiffon Mar 6, 2018

Uh oh!

simonrobb Mar 2, 2018

Uh oh!

tiffon Mar 6, 2018

Uh oh!

simonrobb Mar 2, 2018

Uh oh!

tiffon Mar 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		const context = 'jaeger/ux/trace/kbd-modal';

		export default function trackKbdHelpModal() {

Conversation

tiffon commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tiffon commented Mar 1, 2018

Uh oh!

simonrobb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tiffon commented Mar 1, 2018 •

edited

Loading

codecov bot commented Mar 1, 2018 •

edited

Loading