refactor: add default cases to switch statements for better error handling

Author: Andrei-hub11

cmd/es-rollover/app/lookback/time_reference.go

@@ -25,6 +25,7 @@ func getTimeReference(currentTime time.Time, units string, unitCount int) time.T
 	case "years":
 		year, month, day := currentTime.Date()
 		return time.Date(year, month, day, 0, 0, 0, 0, currentTime.Location()).AddDate(-1*unitCount, 0, 0)
+	default:
+		return currentTime.Truncate(time.Second).Add(-time.Duration(unitCount) * time.Second)
 	}
-	return currentTime.Truncate(time.Second).Add(-time.Duration(unitCount) * time.Second)
 }

cmd/jaeger/internal/extension/jaegerstorage/extension.go

@@ -195,6 +195,8 @@ func (s *storageExt) Start(ctx context.Context, host component.Host) error {
 				*cfg.Opensearch,
 				osTelset,
 			)
+		default:
+			// default case
 		}
 		if err != nil {
 			return fmt.Errorf("failed to initialize storage '%s': %w", storageName, err)
@@ -232,6 +234,8 @@ func (s *storageExt) Start(ctx context.Context, host component.Host) error {
 				*cfg.Opensearch,
 				osTelset,
 			)
+		default:
+			err = fmt.Errorf("no metric backend configuration provided for '%s'", metricStorageName)
 		}
 		if err != nil {
 			return fmt.Errorf("failed to initialize metrics storage '%s': %w", metricStorageName, err)

cmd/jaeger/internal/extension/remotestorage/server_test.go

@@ -77,9 +77,9 @@ func (fakeStorageExt) TraceStorageFactory(name string) (tracestore.Factory, bool
 		return nil, false
 	case "without-dependency-storage":
 		return fakeTraceStorageFactory{name: name}, true
+	default:
+		return newFakeFactory(name), true
 	}
-
-	return newFakeFactory(name), true
 }
 
 func (fakeStorageExt) MetricStorageFactory(string) (storage.MetricStoreFactory, bool) {

examples/hotrod/pkg/tracing/rpcmetrics/metrics.go

@@ -54,6 +54,8 @@ func (m *Metrics) recordHTTPStatusCode(statusCode int64) {
 		m.HTTPStatusCode4xx.Inc(1)
 	case statusCode >= http.StatusInternalServerError && statusCode < 600:
 		m.HTTPStatusCode5xx.Inc(1)
+	default:
+		// Status codes outside standard ranges (< 200 or >= 600) are ignored
 	}
 }
 

examples/hotrod/services/driver/server.go

@@ -44,7 +44,7 @@ func NewServer(hostPort string, otelExporter string, metricsFactory metrics.Fact
 
 // Run starts the Driver server
 func (s *Server) Run() error {
-	lis, err := net.Listen("tcp", s.hostPort)
+	lis, err := (&net.ListenConfig{}).Listen(context.Background(), "tcp", s.hostPort)
 	if err != nil {
 		s.logger.Bg().Fatal("Unable to create http listener", zap.Error(err))
 	}

internal/config/tlscfg/flags_test.go

@@ -209,6 +209,8 @@ func TestFailedTLSFlags(t *testing.T) {
 					case "server":
 						exp := configoptional.Some(configtls.ServerConfig{})
 						require.IsType(t, exp, result, "result should be of type *configtls.ServerConfig")
+					default:
+						t.Errorf("Unexpected side value: %s", metaTest.side)
 					}
 
 					cmdLine[0] = "--prefix.tls.enabled=false"

internal/jptrace/sanitizer/emptyservicename.go

@@ -34,6 +34,8 @@ func sanitizeEmptyServiceName(traces ptrace.Traces) ptrace.Traces {
 			needsModification = true
 		case serviceName.Str() == "":
 			needsModification = true
+		default:
+			// Service name is valid, no modification needed
 		}
 		if needsModification {
 			break
@@ -63,6 +65,8 @@ func sanitizeEmptyServiceName(traces ptrace.Traces) ptrace.Traces {
 			attributes.PutStr(string(otelsemconv.ServiceNameKey), serviceNameWrongType)
 		case serviceName.Str() == "":
 			attributes.PutStr(string(otelsemconv.ServiceNameKey), emptyServiceName)
+		default:
+			// Service name is valid, no action needed
 		}
 	}
 

internal/sampling/samplingstrategy/adaptive/provider_test.go

@@ -123,6 +123,8 @@ func TestProviderRealisticRunCalculationLoop(t *testing.T) {
 		case http.MethodDelete:
 			assert.InEpsilon(t, 0.0005, s.ProbabilisticSampling.SamplingRate, 0.025,
 				"Over sampled, halve probability")
+		default:
+			t.Errorf("Unexpected operation: %s", s.Operation)
 		}
 	}
 }

internal/storage/metricstore/elasticsearch/reader_test.go

@@ -624,6 +624,8 @@ func TestGetLatencies_WithDifferentQuantiles(t *testing.T) {
 				params.Quantile = 0.75
 			case "0.95 quantile":
 				params.Quantile = 0.95
+			default:
+				t.Errorf("Unexpected test case name: %s", tc.name)
 			}
 
 			metricFamily, err := reader.GetLatencies(context.Background(), params)

internal/storage/metricstore/factory.go

@@ -59,8 +59,9 @@ func (*Factory) getFactoryOfType(factoryType string) (storage.V1MetricStoreFacto
 		return prometheus.NewFactory(), nil
 	case disabledStorageType:
 		return disabled.NewFactory(), nil
+	default:
+		return nil, fmt.Errorf("unknown metrics type %q. Valid types are %v", factoryType, AllStorageTypes)
 	}
-	return nil, fmt.Errorf("unknown metrics type %q. Valid types are %v", factoryType, AllStorageTypes)
 }
 
 // Initialize implements storage.V1MetricStoreFactory.