Skip to content

Commit 326edad

Browse files
Remove TODO comment in returnTraces error handling (#7962)
## Description of the changes The TODO questioned how to distinguish internal errors from bad parameters. This distinction is already handled correctly: - Parameter validation occurs in HTTP handlers before QueryService calls - Only storage layer errors reach `returnTraces`, which are legitimately 500 errors. All parameter validation happens before QueryService calls in `getTrace()` and `parseFindTracesQuery()` using tryParamError() ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Sujal Shah <sujalshah28092004@gmail.com>
1 parent 467e974 commit 326edad

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

cmd/jaeger/internal/extension/jaegerquery/internal/apiv3/http_gateway.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ func (h *HTTPGateway) returnTrace(td ptrace.Traces, w http.ResponseWriter) {
122122
}
123123

124124
func (h *HTTPGateway) returnTraces(traces []ptrace.Traces, err error, w http.ResponseWriter) {
125-
// TODO how do we distinguish internal error from bad parameters?
126125
if h.tryHandleError(w, err, http.StatusInternalServerError) {
127126
return
128127
}

0 commit comments

Comments
 (0)