Commit 326edad
authored
Remove TODO comment in returnTraces error handling (#7962)
## Description of the changes
The TODO questioned how to distinguish
internal errors from bad parameters.
This distinction is already handled correctly:
- Parameter validation occurs in HTTP handlers before QueryService calls
- Only storage layer errors reach `returnTraces`, which are legitimately
500 errors.
All parameter validation happens before QueryService calls in
`getTrace()` and `parseFindTracesQuery()` using tryParamError()
## How was this change tested?
-
## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
- for `jaeger`: `make lint test`
- for `jaeger-ui`: `npm run lint` and `npm run test`
Signed-off-by: Sujal Shah <sujalshah28092004@gmail.com>1 parent 467e974 commit 326edad
File tree
1 file changed
+0
-1
lines changed- cmd/jaeger/internal/extension/jaegerquery/internal/apiv3
1 file changed
+0
-1
lines changedLines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | 125 | | |
127 | 126 | | |
128 | 127 | | |
| |||
0 commit comments