Do not exceed ES _id length limit (#905)

* leave document _id generation to Eleasticsearch

Signed-off-by: Tomasz Adamski <tomasz.adamski@gmail.com>

* Calculate sha256 checksum for document _id for Elasticsearch.

Instead of using arbitrary string (which length can be quite big) as
document _id we compute sha256 from it instead.

Signed-off-by: Łukasz Harasimowicz <dev@harnash.eu>

* Using Hashable interface to calculate Elasticsearch ids

Signed-off-by: Łukasz Harasimowicz <dev@harnash.eu>

* Introduce Service::hashCode() to calculate Elasticsearch _id

Signed-off-by: Łukasz Harasimowicz <dev@harnash.eu>

* Do not calculate Service hash in tests

Signed-off-by: Łukasz Harasimowicz <dev@harnash.eu>

Author: tmszdmsk

plugin/storage/es/spanstore/service_operation.go

@@ -16,7 +16,6 @@ package spanstore
 
 import (
 	"context"
-	"fmt"
 	"time"
 
 	"github.com/pkg/errors"
@@ -74,10 +73,10 @@ func (s *ServiceOperationStorage) Write(indexName string, jsonSpan *jModel.Span)
 		ServiceName:   jsonSpan.Process.ServiceName,
 		OperationName: jsonSpan.OperationName,
 	}
-	serviceID := fmt.Sprintf("%s|%s", service.ServiceName, service.OperationName)
-	cacheKey := fmt.Sprintf("%s:%s", indexName, serviceID)
+
+	cacheKey := service.hashCode()
 	if !keyInCache(cacheKey, s.serviceCache) {
-		s.client.Index().Index(indexName).Type(serviceType).Id(serviceID).BodyJson(service).Add()
+		s.client.Index().Index(indexName).Type(serviceType).Id(cacheKey).BodyJson(service).Add()
 		writeCache(cacheKey, s.serviceCache)
 	}
 }

plugin/storage/es/spanstore/service_operation_test.go

@@ -31,9 +31,11 @@ func TestWriteService(t *testing.T) {
 		indexService := &mocks.IndexService{}
 
 		indexName := "jaeger-1995-04-21"
+		serviceHash := "de3b5a8f1a79989d"
+
 		indexService.On("Index", stringMatcher(indexName)).Return(indexService)
 		indexService.On("Type", stringMatcher(serviceType)).Return(indexService)
-		indexService.On("Id", stringMatcher("service|operation")).Return(indexService)
+		indexService.On("Id", stringMatcher(serviceHash)).Return(indexService)
 		indexService.On("BodyJson", mock.AnythingOfType("spanstore.Service")).Return(indexService)
 		indexService.On("Add")
 
@@ -64,9 +66,11 @@ func TestWriteServiceError(t *testing.T) {
 		indexService := &mocks.IndexService{}
 
 		indexName := "jaeger-1995-04-21"
+		serviceHash := "de3b5a8f1a79989d"
+
 		indexService.On("Index", stringMatcher(indexName)).Return(indexService)
 		indexService.On("Type", stringMatcher(serviceType)).Return(indexService)
-		indexService.On("Id", stringMatcher("service|operation")).Return(indexService)
+		indexService.On("Id", stringMatcher(serviceHash)).Return(indexService)
 		indexService.On("BodyJson", mock.AnythingOfType("spanstore.Service")).Return(indexService)
 		indexService.On("Add")
 

plugin/storage/es/spanstore/writer.go

@@ -16,6 +16,8 @@ package spanstore
 
 import (
 	"context"
+	"fmt"
+	"hash/fnv"
 	"strconv"
 	"strings"
 	"time"
@@ -73,6 +75,13 @@ type Span struct {
 	StartTimeMillis uint64 `json:"startTimeMillis"`
 }
 
+func (s Service) hashCode() string {
+	h := fnv.New64a()
+	h.Write([]byte(s.ServiceName))
+	h.Write([]byte(s.OperationName))
+	return fmt.Sprintf("%x", h.Sum64())
+}
+
 // NewSpanWriter creates a new SpanWriter for use
 func NewSpanWriter(
 	client es.Client,

plugin/storage/es/spanstore/writer_test.go

@@ -134,6 +134,7 @@ func TestSpanWriter_WriteSpan(t *testing.T) {
 
 				spanIndexName := "jaeger-span-1995-04-21"
 				serviceIndexName := "jaeger-service-1995-04-21"
+				serviceHash := "de3b5a8f1a79989d"
 
 				serviceExistsService := &mocks.IndicesExistsService{}
 				spanExistsService := &mocks.IndicesExistsService{}
@@ -159,7 +160,7 @@ func TestSpanWriter_WriteSpan(t *testing.T) {
 				indexService.On("Type", stringMatcher(serviceType)).Return(indexServicePut)
 				indexService.On("Type", stringMatcher(spanType)).Return(indexSpanPut)
 
-				indexServicePut.On("Id", stringMatcher("service|operation")).Return(indexServicePut)
+				indexServicePut.On("Id", stringMatcher(serviceHash)).Return(indexServicePut)
 				indexServicePut.On("BodyJson", mock.AnythingOfType("spanstore.Service")).Return(indexServicePut)
 				indexServicePut.On("Add")