Skip to content

Commit abb7a01

Browse files
committed
Simplify
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
1 parent 3011e47 commit abb7a01

File tree

1 file changed

+6
-10
lines changed
  • cmd/opentelemetry/app/exporter/elasticsearchexporter

1 file changed

+6
-10
lines changed

cmd/opentelemetry/app/exporter/elasticsearchexporter/spanstore.go

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -234,25 +234,21 @@ func (w *esSpanWriter) esClientVersion() int {
234234

235235
func bulkItemsToTraces(bulkItems []bulkItem) pdata.Traces {
236236
traces := pdata.NewTraces()
237-
for _, op := range bulkItems {
237+
traces.ResourceSpans().Resize(len(bulkItems))
238+
for i, op := range bulkItems {
238239
spanData := op.spanData
239-
if traces.ResourceSpans().Len() == 0 {
240-
traces.ResourceSpans().Resize(1)
241-
} else {
242-
traces.ResourceSpans().Resize(traces.ResourceSpans().Len())
243-
}
244-
rss := traces.ResourceSpans().At(traces.ResourceSpans().Len() - 1)
240+
rss := traces.ResourceSpans().At(i)
245241
if !spanData.Resource.IsNil() {
246-
spanData.Resource.CopyTo(rss.Resource())
242+
rss.Resource().InitEmpty()
243+
rss.Resource().Attributes().InitFromAttributeMap(spanData.Resource.Attributes())
247244
}
248245
rss.InstrumentationLibrarySpans().Resize(1)
249246
ispans := rss.InstrumentationLibrarySpans().At(0)
250247
ispans.InitEmpty()
251248
if !spanData.InstrumentationLibrary.IsNil() {
252249
spanData.InstrumentationLibrary.CopyTo(ispans.InstrumentationLibrary())
253250
}
254-
ispans.Spans().Resize(1)
255-
spanData.Span.CopyTo(ispans.Spans().At(0))
251+
ispans.Spans().Append(&spanData.Span)
256252
}
257253
return traces
258254
}

0 commit comments

Comments
 (0)