Skip to content

Commit e1fd5ae

Browse files
committed
refactors otel grpc intrumn
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
1 parent 050ba81 commit e1fd5ae

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

examples/hotrod/pkg/tracing/init.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ import (
4545
var once sync.Once
4646

4747
// InitOTEL initializes OpenTelemetry SDK.
48-
func InitOTEL(serviceName string, exporterType string, metricsFactory metrics.Factory, logger log.Factory) trace.Tracer {
48+
func InitOTEL(serviceName string, exporterType string, metricsFactory metrics.Factory, logger log.Factory) trace.TracerProvider {
4949
_, oteltp := initBOTH(serviceName, exporterType, metricsFactory, logger)
5050

5151
logger.Bg().Debug("Created OTEL tracer", zap.String("service-name", serviceName))
52-
return oteltp.Tracer(serviceName)
52+
return oteltp
5353
}
5454

5555
// Init returns OTel-OpenTracing Bridge.

examples/hotrod/services/driver/redis.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,9 @@ type Redis struct {
4242
}
4343

4444
func newRedis(otelExporter string, metricsFactory metrics.Factory, logger log.Factory) *Redis {
45+
tp := tracing.InitOTEL("redis-manual", otelExporter, metricsFactory, logger)
4546
return &Redis{
46-
tracer: tracing.InitOTEL("redis-manual", otelExporter, metricsFactory, logger),
47+
tracer: tp.Tracer("redis-manual"),
4748
logger: logger,
4849
}
4950
}

examples/hotrod/services/driver/server.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ import (
1919
"context"
2020
"net"
2121

22-
otgrpc "github.com/opentracing-contrib/go-grpc"
23-
"github.com/opentracing/opentracing-go"
22+
"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc"
2423
"go.uber.org/zap"
2524
"google.golang.org/grpc"
2625

@@ -32,7 +31,6 @@ import (
3231
// Server implements jaeger-demo-frontend service
3332
type Server struct {
3433
hostPort string
35-
tracer opentracing.Tracer
3634
logger log.Factory
3735
redis *Redis
3836
server *grpc.Server
@@ -42,14 +40,13 @@ var _ DriverServiceServer = (*Server)(nil)
4240

4341
// NewServer creates a new driver.Server
4442
func NewServer(hostPort string, otelExporter string, metricsFactory metrics.Factory, logger log.Factory) *Server {
45-
tracer := tracing.Init("driver", otelExporter, metricsFactory, logger)
43+
tracerProvider := tracing.InitOTEL("driver", otelExporter, metricsFactory, logger)
4644
server := grpc.NewServer(
47-
grpc.UnaryInterceptor(otgrpc.OpenTracingServerInterceptor(tracer)),
48-
grpc.StreamInterceptor(otgrpc.OpenTracingStreamServerInterceptor(tracer)),
45+
grpc.UnaryInterceptor(otelgrpc.UnaryServerInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
46+
grpc.StreamInterceptor(otelgrpc.StreamServerInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
4947
)
5048
return &Server{
5149
hostPort: hostPort,
52-
tracer: tracer,
5350
logger: logger,
5451
server: server,
5552
redis: newRedis(otelExporter, metricsFactory, logger),

0 commit comments

Comments
 (0)