Skip to content

Commit 5511258

Browse files
authored
fix(valid-expect-in-promise): don't crash on it.todo (#1896)
1 parent af94bf1 commit 5511258

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/rules/__tests__/valid-expect-in-promise.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ ruleTester.run('valid-expect-in-promise', rule, {
1414
"test('something', () => Promise.resolve().then(() => expect(1).toBe(2)));",
1515
'Promise.resolve().then(() => expect(1).toBe(2))',
1616
'const x = Promise.resolve().then(() => expect(1).toBe(2))',
17+
'it.todo("something")',
1718
dedent`
1819
it('is valid', () => {
1920
const promise = loadNumber().then(number => {

src/rules/valid-expect-in-promise.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ const isTestCaseCallWithCallbackArg = (
7676
const callbackArgIndex = Number(isJestEach);
7777

7878
return (
79-
isFunction(callback) && callback.params.length === 1 + callbackArgIndex
79+
callback &&
80+
isFunction(callback) &&
81+
callback.params.length === 1 + callbackArgIndex
8082
);
8183
};
8284

0 commit comments

Comments
 (0)