Block transaction selector performance (besu-eth#9023)

* Improve performance of block creation

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Author: fab-10

CHANGELOG.md

@@ -51,6 +51,8 @@
 - Add `WorldStateService` to the plugin API [#9024](https://github.com/hyperledger/besu/pull/9024)
 - Wait for peers before starting Backward Sync [#9003](https://github.com/hyperledger/besu/pull/9003)
 - LUKSO Mainnet Pectra Hardfork [#9070](https://github.com/hyperledger/besu/pull/9070)
+- More informative logs during block creation [#9020](https://github.com/hyperledger/besu/pull/9020)
+- Faster block creation, reducing the time spent committing world state changes [#9023](https://github.com/hyperledger/besu/pull/9023)
 
 #### Dependencies
 - Generate distribution dependencies catalog [#8987](https://github.com/hyperledger/besu/pull/8987)

ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/txselection/BlockTransactionSelector.java

@@ -95,6 +95,7 @@ public class BlockTransactionSelector implements BlockTransactionSelectionServic
   private final Supplier<Boolean> isCancelled;
   private final MainnetTransactionProcessor transactionProcessor;
   private final Blockchain blockchain;
+  //  private final WorldUpdater worldUpdater;
   private final MutableWorldState worldState;
   private final AbstractBlockProcessor.TransactionReceiptFactory transactionReceiptFactory;
   private final BlockSelectionContext blockSelectionContext;
@@ -339,24 +340,27 @@ public TransactionSelectionResult evaluatePendingTransaction(
   @Override
   public boolean commit() {
     // only add this tx to the selected set if it is not too late,
-    // this need to be done synchronously to avoid that a concurrent timeout
+    // this needs to be done synchronously to avoid that a concurrent timeout
     // could start packing a block while we are updating the state here
+    final boolean isTooLate;
     synchronized (isTimeout) {
-      if (!isTimeout.get()) {
+      isTooLate = isTimeout.get();
+      if (!isTooLate) {
         selectorsStateManager.commit();
         txWorldStateUpdater.commit();
         blockWorldStateUpdater.commit();
+        blockWorldStateUpdater.markTransactionBoundary();
         for (final var pendingAction : selectedTxPendingActions) {
           pendingAction.run();
         }
-        selectedTxPendingActions.clear();
-        return true;
       }
     }
+
     selectedTxPendingActions.clear();
     blockWorldStateUpdater = worldState.updater();
     txWorldStateUpdater = blockWorldStateUpdater.updater();
-    return false;
+
+    return !isTooLate;
   }
 
   @Override
@@ -471,7 +475,7 @@ private TransactionSelectionResult handleTransactionSelected(
         transaction.getGasLimit() - processingResult.getGasRemaining();
 
     // queue the creation of the receipt and the update of the final results
-    // there actions will be performed on commit if the pending tx is definitely selected
+    // these actions will be performed on commit if the pending tx is definitely selected
     selectedTxPendingActions.add(
         () -> {
           final long cumulativeGasUsed =