Skip to content

Commit dc52a27

Browse files
committed
build_helper: temporarily swallow remove dir failure
Due to very high failure rate of `tests/mir-opt/strip_debuginfo.rs` for unknown reasons, cf. <rust-lang#134351>.
1 parent b8005bf commit dc52a27

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/build_helper/src/fs/mod.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ where
100100

101101
pub fn remove_and_create_dir_all<P: AsRef<Path>>(path: P) -> io::Result<()> {
102102
let path = path.as_ref();
103-
recursive_remove(path)?;
103+
// FIXME(#134351): for reasons that are not clear yet, `tests/mir-opt/strip_debuginfo.rs`
104+
// triggers various permission denied and dir not empty failures too frequently. Temporarily
105+
// swallow the remove dir failure to make CI failure rate tolerable, but this is mostly likely
106+
// masking a genuine bug, possibly some kind of race condition.
107+
let _ = recursive_remove(path);
104108
fs::create_dir_all(path)
105109
}

0 commit comments

Comments
 (0)