Skip to content

Commit 7cf390e

Browse files
authored
Fixed StatefulSet(sentinel) Label for Service(Selector) OT-CONTAINER-KIT#434 OT-CONTAINER-KIT#435 (OT-CONTAINER-KIT#442)
Signed-off-by: muicoder <muicoder@gmail.com>
1 parent e3f852a commit 7cf390e

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

k8sutils/redis-sentinel.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func CreateRedisSentinelService(cr *redisv1beta1.RedisSentinel) error {
5757
// Create Redis Sentinel Cluster Setup
5858
func (service RedisSentinelSTS) CreateRedisSentinelSetup(cr *redisv1beta1.RedisSentinel) error {
5959

60-
stateFulName := cr.ObjectMeta.Name
60+
stateFulName := cr.ObjectMeta.Name + "-" + service.RedisStateFulType
6161
logger := statefulSetLogger(cr.Namespace, stateFulName)
6262
labels := getRedisLabels(stateFulName, "cluster", service.RedisStateFulType, cr.ObjectMeta.Labels)
6363
annotations := generateStatefulSetsAnots(cr.ObjectMeta)

k8sutils/services.go

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313

1414
const (
1515
redisPort = 6379
16+
sentinelPort = 26379
1617
redisExporterPort = 9121
1718
redisExporterPortName = "redis-exporter"
1819
)
@@ -23,6 +24,15 @@ var (
2324

2425
// generateServiceDef generates service definition for Redis
2526
func generateServiceDef(serviceMeta metav1.ObjectMeta, enableMetrics bool, ownerDef metav1.OwnerReference, headless bool, serviceType string) *corev1.Service {
27+
var PortName string
28+
var PortNum int32
29+
if serviceMeta.Labels["role"] == "sentinel" {
30+
PortName = "sentinel-client"
31+
PortNum = sentinelPort
32+
} else {
33+
PortName = "redis-client"
34+
PortNum = redisPort
35+
}
2636
service := &corev1.Service{
2737
TypeMeta: generateMetaInformation("Service", "v1"),
2838
ObjectMeta: serviceMeta,
@@ -32,9 +42,9 @@ func generateServiceDef(serviceMeta metav1.ObjectMeta, enableMetrics bool, owner
3242
Selector: serviceMeta.GetLabels(),
3343
Ports: []corev1.ServicePort{
3444
{
35-
Name: "redis-client",
36-
Port: redisPort,
37-
TargetPort: intstr.FromInt(int(redisPort)),
45+
Name: PortName,
46+
Port: PortNum,
47+
TargetPort: intstr.FromInt(int(PortNum)),
3848
Protocol: corev1.ProtocolTCP,
3949
},
4050
},

0 commit comments

Comments
 (0)