Skip to content

Commit 2e184f9

Browse files
lrstewartjohubertj
authored andcommitted
# This is a combination of 181 commits.
# This is the 1st commit message: ci: remove S2N_TEST_IN_FIPS_MODE (aws#4994) # This is the commit message aws#2: Migrate PQ Rust code to TLS 1.3 (aws#4998) # This is the commit message aws#3: chore: add new team member (aws#5006) # This is the commit message aws#4: chore(s2n-tls-hyper): Publish s2n-tls-hyper (aws#5000) # This is the commit message aws#5: ci: add script to help launch stuck codebuild jobs (aws#5004) # This is the commit message aws#6: ci: config logging for integration tests (aws#4751) Co-authored-by: Doug Chapman <[email protected]> # This is the commit message aws#7: Migrate PQ Python code to TLS 1.3 (aws#4999) # This is the commit message aws#8: fix: don't prefix empty string when interning (aws#5015) # This is the commit message aws#9: chore: remove unused imports (aws#5017) # This is the commit message aws#10: fix(bindings/bench): Prevent IO from going out of scope (aws#5007) # This is the commit message aws#11: ci: commit integrationv2 small batch spec (aws#5020) # This is the commit message aws#12: ci: keep start_codebuild.sh up-to-date (aws#5023) # This is the commit message aws#13: chore: remove unused test utils (aws#5005) # This is the commit message aws#14: ci: improve output of validate_start_codebuild_script (aws#5031) # This is the commit message aws#15: refactor(bin): remove references to FIPS_mode_set (aws#5026) # This is the commit message aws#16: chore: improve the dashboard comment query (aws#5016) # This is the commit message aws#17: tests: make integV2 locally runnable (aws#5029) # This is the commit message aws#18: feature: remove openssl-1.0.2-fips fips mode support (aws#5030) # This is the commit message aws#19: chore: run more checks on pushes to main (aws#4963) # This is the commit message aws#20: fix: add build specs to copyright check (aws#5025) # This is the commit message aws#21: fix(bindings): Specify correct minimum versions (aws#5028) # This is the commit message aws#22: ci: add timeout for cbmc proof (aws#5038) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#23: test: add sslv2 client hello test w/ jvm (aws#5019) Co-authored-by: Lindsay Stewart <[email protected]> # This is the commit message aws#24: docs: add C / s2n-tls-sys doc references to s2n-tls docs (aws#5012) # This is the commit message aws#25: Add Security Policy Deprecation API (aws#5034) Co-authored-by: James Mayclin <[email protected]> Co-authored-by: Lindsay Stewart <[email protected]> # This is the commit message aws#26: ci: add openssl-3.0-fips builds (aws#5037) # This is the commit message aws#27: fix: initial config should not influence sslv2 (aws#4987) Co-authored-by: maddeleine <[email protected]> # This is the commit message aws#28: chore: bindings release for 0.3.10 (aws#5046) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#29: chore: bump osx Openssl to latest (aws#5041) Signed-off-by: Rui Chen <[email protected]> Co-authored-by: Rui Chen <[email protected]> # This is the commit message aws#30: chore: fix typos (aws#5052) # This is the commit message aws#31: build(deps): bump cross-platform-actions/action from 0.26.0 to 0.27.0 in /.github/workflows in the all-gha-updates group (aws#5053) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> # This is the commit message aws#32: ci: pin duvet version (aws#5057) # This is the commit message aws#33: refactor: remove openssl-1.0.2-fips 'allow md5' logic (aws#5048) # This is the commit message aws#34: ci: Adding integ tests back to integv2 (aws#5054) # This is the commit message aws#35: refactor: cleanup CBMC proofs after aws#5048 (aws#5058) # This is the commit message aws#36: feat(bench): impl into for base config type (aws#5056) # This is the commit message aws#37: Revert "ci: remove openssl-1.0.2-fips builds (aws#4995)" (aws#5060) # This is the commit message aws#38: ci: change rust-toolchain format to toml (aws#5070) # This is the commit message aws#39: ci: Emit benchmark metrics from scheduled runs (aws#5064) # This is the commit message aws#40: fix(bindings): prevent temp connection free after panic (aws#5067) # This is the commit message aws#41: docs(integv2): add architecture diagram (aws#5072) # This is the commit message aws#42: docs(s2n-tls-hyper): Add hyper client/server example (aws#5069) # This is the commit message aws#43: ci: fix dependabot, commit & check Cargo.toml (aws#5065) Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#44: fix(integration): Update PQ integration test expectations (aws#5082) # This is the commit message aws#45: fix: add support for `S2N_INTERN_LIBCRYPTO` with FetchContent (aws#5076) # This is the commit message aws#46: fix: calculation of session ticket age (aws#5001) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#47: fix: error for uninit psk, check for all-zero psk (aws#5084) # This is the commit message aws#48: fix: don't use DEPENDS with add_custom_command(TARGET) (aws#5074) # This is the commit message aws#49: fix(ci): Allow validate_start_codebuild to run on pushes to main (aws#5080) # This is the commit message aws#50: test: add minimal openssl-3.0-fips test (aws#5081) # This is the commit message aws#51: feat(bindings): add external psk apis (aws#5061) # This is the commit message aws#52: Fixed formatting for debugging statements (aws#5094) # This is the commit message aws#53: chore: ktls buildspec (aws#5083) # This is the commit message aws#54: chore: bindings release 0.3.11 (aws#5098) # This is the commit message aws#55: fix(integrationv2): Skip unsupported client auth tests (aws#5096) Co-authored-by: James Mayclin <[email protected]> # This is the commit message aws#56: build(deps): bump aws-actions/configure-aws-credentials from 4.0.2 to 4.1.0 in /.github/workflows in the all-gha-updates group across 1 directory (aws#5107) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> # This is the commit message aws#57: refactor: remove s2n_hmac_is_available (aws#5104) # This is the commit message aws#58: refactor: remove unused evp support for md5+sha1 (aws#5106) # This is the commit message aws#59: fix: allow b64 decoding using libcrypto for sidechannel resistance (aws#5103) Co-authored-by: Sam Clark <[email protected]> Co-authored-by: Doug Chapman <[email protected]> # This is the commit message aws#60: fix: don't enable custom random for openssl fips (aws#5093) Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#61: ci: add default provider to openssl-3.0-fips (aws#5114) # This is the commit message aws#62: Revert "refactor: remove unused evp support for md5+sha1 (aws#5106)" (aws#5118) # This is the commit message aws#63: Add new security policy (20250211) (aws#5111) # This is the commit message aws#64: refactor: move "s2n_libcrypto_is" methods into s2n_libcrypto.h (aws#5117) # This is the commit message aws#65: bindings: unpin openssl crate from a specific patch version (aws#5120) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#66: chore: fix a typo in API comments (aws#5123) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#67: build(deps): update rand requirement (aws#5125) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#68: fix(bindings): make Context borrow immutable (aws#5071) # This is the commit message aws#69: feat: Option to disable RAND engine override (aws#5108) # This is the commit message aws#70: refactor: use EVP_MD_fetch() if available (aws#5116) Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#71: chore: binding release 0.3.12 (aws#5128) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#72: fix(bindings): remove mutation behind Arc (aws#5124) # This is the commit message aws#73: chore: remove unused well-known-endpoints.py (aws#5127) # This is the commit message aws#74: feat: add async cert validation support (aws#5110) # This is the commit message aws#75: ci: add check for third-party-src in disable rand override buildspec (aws#5137) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#76: refactor: always use EVP hashing (aws#5121) # This is the commit message aws#77: fix: update callback return value (aws#5136) # This is the commit message aws#78: ci: always set values for command line defines (aws#5126) # This is the commit message aws#79: tests: use sig schemes as source of truth for valid hash+sig algs (aws#5129) # This is the commit message aws#80: build(deps): update rtshark requirement from 2.9.0 to 3.1.0 in /tests/pcap in the all-cargo-updates group across 1 directory (aws#5087) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> # This is the commit message aws#81: test(integv2): fixes to allow test_record_padding to partially run (aws#5099) Co-authored-by: James Mayclin <[email protected]> # This is the commit message aws#82: chore(nix): Add aws-lc-fips 2022/4 (aws#5109) Co-authored-by: Lindsay Stewart <[email protected]> # This is the commit message aws#83: Ruff Formatting and add to CI (aws#5138) Co-authored-by: James Mayclin <[email protected]> # This is the commit message aws#84: feat(bindings): expose context on cert chain (aws#5132) Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#85: refactor: cleanup prf header (aws#5144) # This is the commit message aws#86: refactor: add alternative EVP signing method (aws#5141) # This is the commit message aws#87: fix: memory leak during STEK rotation (aws#5146) # This is the commit message aws#88: chore(ci): make the awslc fips install script version aware (aws#5100) Co-authored-by: Lindsay Stewart <[email protected]> Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#89: refactor: remove unused prf hmac impls (aws#5148) # This is the commit message aws#90: chore(bindings): change in rustup behavior (aws#5160) # This is the commit message aws#91: chore: git-blame-ignore ruff formatting (aws#5151) # This is the commit message aws#92: tests: try to make s2n_mem_usage_test more useful (aws#5139) Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#93: chore(ci): pin symbolic-common (aws#5166) # This is the commit message aws#94: chore: binding release 0.3.13 (aws#5167) # This is the commit message aws#95: refactor: add libcrypto PRF impl for openssl-3.0-fips (aws#5158) # This is the commit message aws#96: build(deps): bump nixbuild/nix-quick-install-action from 29 to 30 in /.github/workflows in the all-gha-updates group (aws#5153) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> # This is the commit message aws#97: style: fix redundant return (aws#5150) # This is the commit message aws#98: chore: update git blame ignore commit ID (aws#5164) # This is the commit message aws#99: tests: fix flaky ja4 test (aws#5169) # This is the commit message aws#100: fix: mark chachapoly as unavailable with openssl-3.0-fips (aws#5168) # This is the commit message aws#101: fix(ruff): resolve linting errors detected by Ruff (aws#5140) # This is the commit message aws#102: chore: pin once_cell version to unblock the CI (aws#5174) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#103: ci: use ruff --diff instead of --check (aws#5177) # This is the commit message aws#104: (docs): Improve PQ docs (aws#5173) Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#105: test(integv2): add partial support for OpenSSL 3.0 provider (aws#5131) Co-authored-by: James Mayclin <[email protected]> # This is the commit message aws#106: ci: make start_codebuild.sh work for forks (aws#5178) # This is the commit message aws#107: chore: add inline noqa suppression (aws#5159) # This is the commit message aws#108: test: reduce parameter selection (aws#5161) # This is the commit message aws#109: test: fix self-talk pkey offload test for openssl-3.0-fips (aws#5175) # This is the commit message aws#110: build(deps): update aws-lc-rs version to remove paste deps (aws#5192) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#111: chore: bump linting action Ubuntu version (aws#5186) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#112: ci: cleanup awslc-fips versioning (aws#5156) # This is the commit message aws#113: chore: include Need By Date section in github issue template (aws#5187) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#114: ci: move openssl3fips build to existing asan build (aws#5181) # This is the commit message aws#115: fix: openssl-3.0-fips should use separate private rand (aws#5184) # This is the commit message aws#116: fix: remove unnecessary RC4 restriction (aws#5170) # This is the commit message aws#117: fix: openssl-3.0-fips should use libcrypto HKDF (aws#5183) Co-authored-by: Sam Clark <[email protected]> # This is the commit message aws#118: ci: defend against unset version number in awslc installer (aws#5195) # This is the commit message aws#119: feature: openssl-3.0-fips support (aws#5191) # This is the commit message aws#120: ci: add libcrypto openssl-3.0-fips to integ tests (aws#5202) # This is the commit message aws#121: ci: add openssl-3.0-fips to asan build properly (aws#5204) # This is the commit message aws#122: fix: handshake message length integer overflow in s2n_handshake_finish_header (aws#5206) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#123: chore: deprecate s2n_set (aws#5155) # This is the commit message aws#124: chore: binding release 0.3.14 (aws#5210) # This is the commit message aws#125: Remove PQ TLS 1.2 from all Security Policies (aws#5194) # This is the commit message aws#126: ci: exclude new setuptools (aws#5215) # This is the commit message aws#127: fix: Update README.md to include Rust bindings docs (aws#5212) # This is the commit message aws#128: feat: add s2n_connection_get_key_exchange_group (aws#5209) # This is the commit message aws#129: chore: bindings release 0.3.15 (aws#5221) # This is the commit message aws#130: ci: add openssl-3.0-fips to valgrind (aws#5211) # This is the commit message aws#131: docs: fix openssl-3.0-fips provider requirements documentation (aws#5214) # This is the commit message aws#132: refactor(bindings): use implicit linking for aws-lc (aws#5218) # This is the commit message aws#133: fix: tighten session ticket lifetime (aws#5217) # This is the commit message aws#134: ci: Fix cppcheck build (aws#5238) # This is the commit message aws#135: refactor: implement match the same for all pkeys (aws#5224) # This is the commit message aws#136: ci: add openssl-3.0-fips to general batch (aws#5207) # This is the commit message aws#137: refactor: add evp pkey size/encrypt/decrypt methods (aws#5225) # This is the commit message aws#138: feat(bindings): expose certificate match api (aws#5220) Co-authored-by: James Mayclin <[email protected]> # This is the commit message aws#139: ci: add ruff linting (aws#5182) # This is the commit message aws#140: ci: pin nix installer to older version (aws#5245) # This is the commit message aws#141: chore: Fix new clippy warning (aws#5243) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#142: ci: rebalance integV2 testcases (aws#5232) # This is the commit message aws#143: fix: tainted handshake.io and add large client hello test (aws#5208) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#144: chore: bindings release 0.3.16 (aws#5242) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#145: refactor: remove legacy pkey impls (aws#5241) # This is the commit message aws#146: Revert "ci: exclude new setuptools (aws#5215)" (aws#5226) # This is the commit message aws#147: fix: make -fPIC flag private (aws#5227) Co-authored-by: Souvik Banerjee <[email protected]> # This is the commit message aws#148: doc: tainted stuffer reset operation (aws#5231) Co-authored-by: Boquan Fang <[email protected]> # This is the commit message aws#149: feat: Expose `as_ptr()` for external build (aws#5229) # This is the commit message aws#150: ci: pytest generate junit reports (aws#5235) # This is the commit message aws#151: add compiler flag # This is the commit message aws#152: added c check x86 and correct compiler # This is the commit message aws#153: cmake fix # This is the commit message aws#154: testing # This is the commit message aws#155: removed clang # This is the commit message aws#156: Print statements # This is the commit message aws#157: compiler check # This is the commit message aws#158: print # This is the commit message aws#159: find clang # This is the commit message aws#160: branch probing # This is the commit message aws#161: removed individual probing # This is the commit message aws#162: removed old unneeded changes # This is the commit message aws#163: added back original line # This is the commit message aws#164: fixed .c file # This is the commit message aws#165: ci: use correct openssl version for updated AL2023 version (aws#5255) # This is the commit message aws#166: chore(ci): revert nix installer pin (aws#5251) # This is the commit message aws#167: ci: add awslcfips to nix jobs (aws#5205) Co-authored-by: Copilot <[email protected]> # This is the commit message aws#168: moved adding options to the bottom # This is the commit message aws#169: copmiler debug prints # This is the commit message aws#170: clang printout # This is the commit message aws#171: remove setting compiler to clang # This is the commit message aws#172: set clang as default # This is the commit message aws#173: remove clang # This is the commit message aws#174: move fuzz cmake into it's own directory # This is the commit message aws#175: fixed path to fuzz # This is the commit message aws#176: back to original # This is the commit message aws#177: only branch if we're not fuzz tests # This is the commit message aws#178: add clang back now # This is the commit message aws#179: removed debugging prints # This is the commit message aws#180: removed checking for compiler # This is the commit message aws#181: testing move back original block
1 parent 7220e23 commit 2e184f9

File tree

444 files changed

+11347
-8593
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

444 files changed

+11347
-8593
lines changed

.git-blame-ignore-revs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,5 @@ f5351ef6629d1f6de144ab478bf4294ec277b321
3939
e8cdc1ae63ff1de6f14cf91e3c317fbf57c198ec
4040
# clang-format `utils/` and enforce in ci (#3651)
4141
be8ad6c027b50e9dc86d8f8eb729ce88f2d4206d
42+
# Ruff format updated CI and code (#5138)
43+
ac1d09851b4d625f83d1fa68b467abbca8fdd408

.github/ISSUE_TEMPLATE/custom.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ AWS Security via our [vulnerability reporting page](http://aws.amazon.com/securi
1717

1818
A short description of what the problem is and why we need to fix it. Add reproduction steps if necessary.
1919

20+
### Need By Date:
21+
22+
Do you have a date that you need this issue resolved by? What is the reason for that date, and what are the consequences of missing it? Any additional information you can provide to help prioritize the issue is appreciated. However, we cannot guarantee that this issue will be fixed by the requested date.
23+
2024
### Solution:
2125

2226
A description of the possible solution in terms of S2N architecture. Highlight and explain any potentially controversial design decisions taken.

.github/ISSUE_TEMPLATE/s2n-issue.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ AWS Security via our [vulnerability reporting page](http://aws.amazon.com/securi
1616

1717
A short description of what the problem is and why we need to fix it. Add reproduction steps if necessary.
1818

19+
### Need By Date:
20+
21+
Do you have a date that you need this issue resolved by? What is the reason for that date, and what are the consequences of missing it? Any additional information you can provide to help prioritize the issue is appreciated. However, we cannot guarantee that this issue will be fixed by the requested date.
22+
1923
### Solution:
2024

2125
A description of the possible solution in terms of S2N architecture. Highlight and explain any potentially controversial design decisions taken.

.github/dependabot.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ updates:
3131
# restricted-MSRV, so don't do batch updates
3232
- package-ecosystem: "cargo"
3333
directories:
34-
- "/bindings/rust"
34+
- "/bindings/rust/standard"
35+
- "/bindings/rust/extended"
3536
schedule:
3637
interval: "daily"

.github/install_osx_dependencies.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ brew_install_if_not_installed coreutils
2626
brew_install_if_not_installed cppcheck
2727
brew_install_if_not_installed pkg-config # for gnutls compilation
2828
brew_install_if_not_installed ninja
29-
brew_install_if_not_installed openssl@1.1 # for libcrypto
29+
brew_install_if_not_installed openssl@3 # for libcrypto

.github/s2n_osx.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,25 @@
1414
# permissions and limitations under the License.
1515
#
1616
set -eu
17-
source codebuild/bin/s2n_setup_env.sh
1817

18+
export S2N_LIBCRYPTO=openssl-3.4
1919
export CTEST_OUTPUT_ON_FAILURE=1
20-
BREWINSTLLPATH=$(brew --prefix openssl@1.1)
21-
OPENSSL_1_1_1_INSTALL_DIR="${BREWINSTLLPATH:-"/usr/local/Cellar/openssl@1.1/1.1.1?"}"
20+
BREWINSTLLPATH=$(brew --prefix openssl@3)
21+
OPENSSL_3_INSTALL_DIR="${BREWINSTLLPATH:-"/opt/homebrew/Cellar/openssl@3"}"
2222

23-
echo "Using OpenSSL at $OPENSSL_1_1_1_INSTALL_DIR"
23+
echo "Using OpenSSL at $OPENSSL_3_INSTALL_DIR"
2424
# Build with debug symbols and a specific OpenSSL version
2525
cmake . -Bbuild -GNinja \
2626
-DCMAKE_BUILD_TYPE=Debug \
27-
-DCMAKE_PREFIX_PATH=${OPENSSL_1_1_1_INSTALL_DIR} ..
27+
-DCMAKE_PREFIX_PATH=${OPENSSL_3_INSTALL_DIR} ..
2828

2929
cmake --build ./build -j $(nproc)
3030
time CTEST_PARALLEL_LEVEL=$(nproc) ninja -C build test
3131

3232
# Build shared library
3333
cmake . -Bbuild -GNinja \
3434
-DCMAKE_BUILD_TYPE=Debug \
35-
-DCMAKE_PREFIX_PATH=${OPENSSL_1_1_1_INSTALL_DIR} .. \
35+
-DCMAKE_PREFIX_PATH=${OPENSSL_3_INSTALL_DIR} .. \
3636
-DBUILD_SHARED_LIBS=ON
3737

3838
cmake --build ./build -j $(nproc)

.github/teams.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ s2n-core:
88
- '@jmayclin'
99
- '@jouho'
1010
- '@boquan-fang'
11-
- '@CarolYeh910'
11+
- '@CarolYeh910'
12+
- '@johubertj'

.github/workflows/bench.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Benchmarking
22

33
on:
4+
pull_request:
5+
branches: [main]
46
push:
57
branches: [main]
68
schedule:
@@ -29,23 +31,26 @@ jobs:
2931
pip3 install "boto3[crt]"
3032
3133
- name: Generate
32-
working-directory: bindings/rust
34+
working-directory: bindings/rust/extended
3335
run: ./generate.sh --skip-tests
3436

3537
- name: Benchmark
36-
working-directory: bindings/rust/bench
38+
working-directory: bindings/rust/standard/bench
3739
run: cargo criterion --message-format json > criterion_output.log
3840

3941
- name: Configure AWS Credentials
40-
uses: aws-actions/[email protected]
42+
# Only continue with the workflow to emit metrics on code that has been merged to main.
43+
if: github.event_name != 'pull_request'
44+
uses: aws-actions/[email protected]
4145
with:
4246
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCRole
4347
role-session-name: s2ntlsghabenchsession
4448
aws-region: us-west-2
4549

4650
- name: Emit CloudWatch metrics
51+
if: github.event_name != 'pull_request'
4752
run: |
4853
python3 .github/bin/criterion_to_cloudwatch.py \
49-
--criterion_output_path bindings/rust/bench/criterion_output.log \
54+
--criterion_output_path bindings/rust/standard/bench/criterion_output.log \
5055
--namespace s2n-tls-bench \
5156
--platform ${{ runner.os }}-${{ runner.arch }}

.github/workflows/ci_compliance.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
- name: Run duvet action
3232
uses: ./s2n-quic/.github/actions/duvet
3333
with:
34+
duvet-version: 0.3.0 # Pin until we fix parsing issues
3435
s2n-quic-dir: ./s2n-quic
3536
report-script: compliance/generate_report.sh
3637
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCRole

.github/workflows/ci_freebsd.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: FreeBSD
22

33
on:
4+
push:
5+
branches: [main]
46
pull_request:
57
branches: [main]
68
merge_group:

.github/workflows/ci_linting.yml

Lines changed: 75 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
---
22
name: Linters
33
on:
4+
push:
5+
branches: [main]
46
pull_request:
57
branches: [main]
68
merge_group:
79
types: [checks_requested]
810
branches: [main]
911
jobs:
1012
cppcheck:
11-
# ubuntu-latest introduced a newer gcc version that cannot compile cppcheck 2.3
12-
# TODO: upgrade to latest cppcheck and revert to ubuntu-latest
13-
# see https://github.com/aws/s2n-tls/issues/3656
14-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-latest
1514
env:
1615
CPPCHECK_INSTALL_DIR: test-deps/cppcheck
1716
steps:
@@ -72,21 +71,40 @@ jobs:
7271
run: |
7372
./codebuild/bin/run_kwstyle.sh
7473
./codebuild/bin/cpp_style_comment_linter.sh
75-
pepeight:
74+
75+
ruff:
7676
runs-on: ubuntu-latest
7777
steps:
7878
- name: checkout
7979
uses: actions/checkout@v4
80-
- name: Run autopep8
81-
id: autopep8
82-
uses: peter-evans/autopep8@v2
83-
with:
84-
args: --diff --exit-code .
85-
- name: Check exit code
86-
if: steps.autopep8.outputs.exit-code != 0
80+
81+
- name: Set up uv
82+
uses: astral-sh/setup-uv@v5
83+
84+
- name: Run Ruff formatting check
85+
working-directory: tests/integrationv2
86+
id: ruff_format
87+
run: uv run ruff format --diff .
88+
continue-on-error: true
89+
90+
- name: Check format exit code
91+
if: steps.ruff_format.outcome == 'failure'
8792
run: |
88-
echo "Run 'autopep8 --in-place .' to fix"
93+
echo "Run 'ruff format .' to fix formatting issues"
8994
exit 1
95+
96+
- name: Run Ruff lint check
97+
working-directory: tests/integrationv2
98+
id: ruff_lint
99+
run: uv run ruff check .
100+
continue-on-error: true
101+
102+
- name: Check lint exit code
103+
if: steps.ruff_lint.outcome == 'failure'
104+
run: |
105+
echo "Linting issues detected. Run 'ruff check .' locally to see errors and fix them."
106+
exit 1
107+
90108
clang-format:
91109
runs-on: ubuntu-latest
92110
steps:
@@ -101,7 +119,7 @@ jobs:
101119
runs-on: ubuntu-latest
102120
steps:
103121
- uses: actions/checkout@v4
104-
- uses: nixbuild/nix-quick-install-action@v29
122+
- uses: nixbuild/nix-quick-install-action@v30
105123
with:
106124
nix_conf: experimental-features = nix-command flakes
107125
- name: nix flake check
@@ -110,7 +128,7 @@ jobs:
110128
runs-on: ubuntu-latest
111129
steps:
112130
- uses: actions/checkout@v4
113-
- uses: nixbuild/nix-quick-install-action@v29
131+
- uses: nixbuild/nix-quick-install-action@v30
114132
with:
115133
nix_conf: experimental-features = nix-command flakes
116134
- name: nix fmt
@@ -128,3 +146,45 @@ jobs:
128146
exit 1
129147
- name: Success
130148
run: echo "All nix files passed format check"
149+
150+
validate_start_codebuild_script:
151+
name: validate start_codebuild.sh
152+
runs-on: ubuntu-latest
153+
steps:
154+
- uses: actions/checkout@v4
155+
- name: pause
156+
run: "sleep 120"
157+
- name: retrieve statuses
158+
id: get_statuses
159+
uses: octokit/[email protected]
160+
with:
161+
route: GET /repos/{repo}/commits/{ref}/statuses?per_page=100
162+
repo: ${{ github.repository }}
163+
ref: ${{ github.event.merge_group.head_sha || github.event.pull_request.head.sha || github.event.after }}
164+
env:
165+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
166+
- name: check start_codebuild.sh against statuses
167+
id: github_builds
168+
run: |
169+
from_github=$(
170+
jq '.[] | .description' <<< '${{ steps.get_statuses.outputs.data }}' \
171+
| grep "for project" \
172+
| sed -r "s/^.*?for project (.*?)\"$/\1/" \
173+
| sort -u
174+
)
175+
if [ -z "$from_github" ]; then
176+
echo "No codebuild job statuses!"
177+
echo "You may need to kick off the codebuild jobs with" \
178+
"./codebuild/bin/start_codebuild.sh and then retry."
179+
exit 1
180+
fi
181+
echo builds from github statuses:
182+
printf "$from_github\n\n"
183+
from_file=$(
184+
source codebuild/bin/start_codebuild.sh > /dev/null \
185+
|| printf "%s\n" "${BUILDS[@]}" | cut -d" " -f1 | sort -u
186+
)
187+
echo builds from start_codebuild.sh:
188+
printf "$from_file\n\n"
189+
echo "diff output:"
190+
diff <(echo "$from_github") <(echo "$from_file")

.github/workflows/ci_openbsd.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: OpenBSD
22

33
on:
4+
push:
5+
branches: [main]
46
pull_request:
57
branches: [main]
68
merge_group:
@@ -15,7 +17,7 @@ jobs:
1517
- uses: actions/checkout@v4
1618
- name: Build and test in OpenBSD
1719
id: test
18-
uses: cross-platform-actions/action@v0.26.0
20+
uses: cross-platform-actions/action@v0.27.0
1921
with:
2022
operating_system: openbsd
2123
architecture: x86-64

0 commit comments

Comments
 (0)