Skip to content

Commit 3f61417

Browse files
authored
Merge pull request #2028 from AndreMiras/fix/coveralls-zero-coverage
💚 Restore py3 env so coverage actually runs
2 parents 461c8aa + d4cea41 commit 3f61417

4 files changed

Lines changed: 18 additions & 18 deletions

File tree

.github/workflows/test_python.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ jobs:
44
Tests:
55
name: base
66
strategy:
7+
fail-fast: false
78
matrix:
89
python:
910
- '3.8'

tests/targets/test_android.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def test_init(self):
115115
assert target_android.extra_p4a_args == [
116116
"--color=always",
117117
f"--storage-dir={buildozer.buildozer_dir}/android/platform/build-arm64-v8a_armeabi-v7a",
118-
"--ndk-api=21",
118+
"--ndk-api=24",
119119
"--ignore-setup-py",
120120
"--debug",
121121
]
@@ -227,8 +227,8 @@ def test_build_package(self):
227227
("--name", "My Application"),
228228
("--version", "0.1"),
229229
("--package", "org.test.myapp"),
230-
("--minsdk", "21"),
231-
("--ndk-api", "21"),
230+
("--minsdk", "24"),
231+
("--ndk-api", "24"),
232232
("--private", "{buildozer_dir}/android/app".format(buildozer_dir=buildozer.buildozer_dir)),
233233
("--android-entrypoint", "org.kivy.android.PythonActivity"),
234234
("--android-apptheme", "@android:style/Theme.NoTitleBar"),
@@ -322,8 +322,8 @@ def test_numeric_version(self):
322322
("--name", "My Application"),
323323
("--version", "0.1"),
324324
("--package", "org.test.myapp"),
325-
("--minsdk", "21"),
326-
("--ndk-api", "21"),
325+
("--minsdk", "24"),
326+
("--ndk-api", "24"),
327327
("--private", "{buildozer_dir}/android/app".format(buildozer_dir=buildozer.buildozer_dir)),
328328
("--android-entrypoint", "org.kivy.android.PythonActivity"),
329329
("--android-apptheme", "@android:style/Theme.NoTitleBar"),
@@ -358,8 +358,8 @@ def test_build_package_intent_filters(self):
358358
('--name', "My Application"),
359359
('--version', '0.1'),
360360
('--package', 'org.test.myapp'),
361-
('--minsdk', '21'),
362-
('--ndk-api', '21'),
361+
('--minsdk', '24'),
362+
('--ndk-api', '24'),
363363
('--private', '{buildozer_dir}/android/app'.format(buildozer_dir=buildozer.buildozer_dir)),
364364
('--android-entrypoint', 'org.kivy.android.PythonActivity'),
365365
('--android-apptheme', '@android:style/Theme.NoTitleBar'),
@@ -385,8 +385,8 @@ def test_allow_backup(self):
385385
("--name", "My Application"),
386386
("--version", "0.1"),
387387
("--package", "org.test.myapp"),
388-
("--minsdk", "21"),
389-
("--ndk-api", "21"),
388+
("--minsdk", "24"),
389+
("--ndk-api", "24"),
390390
("--private", "{buildozer_dir}/android/app".format(buildozer_dir=buildozer.buildozer_dir)),
391391
("--android-entrypoint", "org.kivy.android.PythonActivity"),
392392
("--android-apptheme", "@android:style/Theme.NoTitleBar"),
@@ -412,8 +412,8 @@ def test_backup_rules(self):
412412
("--name", "My Application"),
413413
("--version", "0.1"),
414414
("--package", "org.test.myapp"),
415-
("--minsdk", "21"),
416-
("--ndk-api", "21"),
415+
("--minsdk", "24"),
416+
("--ndk-api", "24"),
417417
("--private", "{buildozer_dir}/android/app".format(buildozer_dir=buildozer.buildozer_dir)),
418418
("--android-entrypoint", "org.kivy.android.PythonActivity"),
419419
("--android-apptheme", "@android:style/Theme.NoTitleBar"),
@@ -482,8 +482,8 @@ def test_orientation(self):
482482
("--name", "My Application"),
483483
("--version", "0.1"),
484484
("--package", "org.test.myapp"),
485-
("--minsdk", "21"),
486-
("--ndk-api", "21"),
485+
("--minsdk", "24"),
486+
("--ndk-api", "24"),
487487
("--private", "{buildozer_dir}/android/app".format(buildozer_dir=buildozer.buildozer_dir)),
488488
("--android-entrypoint", "org.kivy.android.PythonActivity"),
489489
("--android-apptheme", "@android:style/Theme.NoTitleBar"),
@@ -508,8 +508,8 @@ def test_manifest_orientation(self):
508508
("--name", "My Application"),
509509
("--version", "0.1"),
510510
("--package", "org.test.myapp"),
511-
("--minsdk", "21"),
512-
("--ndk-api", "21"),
511+
("--minsdk", "24"),
512+
("--ndk-api", "24"),
513513
("--private", "{buildozer_dir}/android/app".format(buildozer_dir=buildozer.buildozer_dir)),
514514
("--android-entrypoint", "org.kivy.android.PythonActivity"),
515515
("--android-apptheme", "@android:style/Theme.NoTitleBar"),

tests/test_buildops.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,7 @@ def test_checkbin(self):
441441
"buildozer.buildops.LOGGER"
442442
) as m_logger:
443443

444-
assert buildops.checkbin("Python", "python")
445-
# Probably ^ == executable, but not always in the CI environment.
444+
assert buildops.checkbin("Python", executable)
446445
m_logger.debug.assert_called()
447446
m_exit.assert_not_called()
448447
m_logger.error.assert_not_called()

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = pep8
2+
envlist = pep8, py3
33

44
[testenv]
55
deps =

0 commit comments

Comments
 (0)