-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Replacements: better support for targeting --key=value container args #4080
Copy link
Copy link
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Is your feature request related to a problem? Please describe.
A huge value-add to using
replacementsover traditional JSON patches is the ability to use[key=value]selectors in field paths. This makes your patches much more robust since the alternative relies on array field ordering. Unfortunately, this is still true when the field path value is a simple string array... most notably in the case of containerargs.Describe the solution you'd like
In situations like the following, it would be ideal if we could reliably replace the value of
--leader-election-namespace:I'm not sure how we would represent this in the
replacementsAPI, but it could look something like:The new rules would be:
indexanddelimiteroptions can only be specified on scalar values and lists consisting only of string valuesprefixand/orsuffixoptions are specified,prefixandsuffixprefixand/orsuffixis preserved in the resulting valuedelimiter, only the unprefixed/suffixed portion of the string is split