changed sec group nil check from findSecurityGroup

gargipanatula · gargipanatula · commit bd1b727b7b29 · 2025-08-18T15:56:09.000-07:00
diff --git a/pkg/providers/v1/aws_loadbalancer.go b/pkg/providers/v1/aws_loadbalancer.go
@@ -816,9 +816,12 @@ func (c *Cloud) updateInstanceSecurityGroupsForNLB(ctx context.Context, lbName s
 	{
 		for sgID := range desiredSGIDs.Difference(sets.StringKeySet(clusterSGs)) {
 			sg, err := c.findSecurityGroup(ctx, sgID)
-			if err != nil || sg == nil {
+			if err != nil {
 				return fmt.Errorf("error finding instance group: %q", err)
 			}
+			if sg == nil {
+				return fmt.Errorf("error finding security group: %s", sgID)
+			}
 			clusterSGs[sgID] = sg
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -816,9 +816,12 @@ func (c *Cloud) updateInstanceSecurityGroupsForNLB(ctx context.Context, lbName s`
`816`	`816`	`{`
`817`	`817`	`for sgID := range desiredSGIDs.Difference(sets.StringKeySet(clusterSGs)) {`
`818`	`818`	`sg, err := c.findSecurityGroup(ctx, sgID)`
`819`		`- if err != nil \|\| sg == nil {`
	`819`	`+ if err != nil {`
`820`	`820`	`return fmt.Errorf("error finding instance group: %q", err)`
`821`	`821`	`}`
	`822`	`+ if sg == nil {`
	`823`	`+ return fmt.Errorf("error finding security group: %s", sgID)`
	`824`	`+ }`
`822`	`825`	`clusterSGs[sgID] = sg`
`823`	`826`	`}`
`824`	`827`	`}`