Skip to content

Commit 0d48147

Browse files
committed
KEP-4742: fix topology labels
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent ef7e11d commit 0d48147

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

keps/sig-node/4742-node-topology-downward-api/README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ we aim to simplify access to this information for Pods via the Downward API.
9898

9999
### Goals
100100

101-
* Values from Node labels `topology.k8s.io/zone`, `topology.k8s.io/region` and `kubernetes.io/hostname` are made
101+
* Values from Node labels `topology.kubernetes.io/zone`, `topology.kubernetes.io/region` and `kubernetes.io/hostname` are made
102102
available via downward API
103103
* Additional node labels can be made available via downward API using admission webhooks that mutate `pods/binding`.
104104

@@ -225,7 +225,8 @@ E2E tests will also ensure behavior is exercised when the feature gate is enable
225225

226226
#### Beta
227227

228-
TODO after Alpha.
228+
- Fix standard topology label used in PodTopologyLabels admission controller (topology.k8s.io -> topology.kubernetes.io)
229+
- Unit, integration and e2e tests
229230

230231
#### GA
231232

@@ -290,7 +291,9 @@ Tests will be added to ensure feature gate works as expected.
290291

291292
### Rollout, Upgrade and Rollback Planning
292293

293-
TODO for Beta.
294+
Manual testing will be exercised to ensure that PodTopologyLabelsAdmission can be enabled and then disabled.
295+
When disabled, existing Pods with topology labels will continue to run with those labels and new Pods will no longer
296+
container topology labels.
294297

295298
###### How can a rollout or rollback fail? Can it impact already running workloads?
296299

@@ -402,6 +405,7 @@ Revert feature gate and stop consuming downward API.
402405
## Implementation History
403406

404407
- `v1.33`: initial KEP is accepeted and alpha implementation is complete
408+
- `v1.34`: fix topology labels from topology.k8s.io to topology.kubernetes.io.
405409

406410
## Drawbacks
407411

keps/sig-node/4742-node-topology-downward-api/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ stage: alpha
2626
# The most recent milestone for which work toward delivery of this KEP has been
2727
# done. This can be the current (upcoming) milestone, if it is being actively
2828
# worked on.
29-
latest-milestone: "v1.33"
29+
latest-milestone: "v1.34"
3030

3131
# The milestone at which this feature was, or is targeted to be, at each stage.
3232
milestone:
3333
alpha: "v1.33"
34-
# beta: "v1.34"
34+
beta: "v1.35"
3535
# stable: "v1.35"
3636

3737
# The following PRR answers are required at alpha release

0 commit comments

Comments
 (0)