This repository was archived by the owner on Jul 24, 2024. It is now read-only.
chore(data/mv_polynomial): use classical logic #1391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2019 13:25
kim-em
changed the title
|
Sorry, there's still some more files that I missed, so I'm marking this as WIP. |
|
@jcommelin, @kckennylau, I've run into quite a few problems in |
Thanks! We're down to one remaining problem, described above in the discussion with Mario. |
kim-em
changed the title
7 tasks
butterthebuddha
pushed a commit
to butterthebuddha/mathlib
that referenced
this pull request
May 15, 2020
…1391) * refactor(linear_algebra/lc): use families not sets * refactor(linear_algebra/lc): merge lc into finsupp * refactor(linear_algebra/lc): localize decidability * refactor(linear_algebra/lc): finsupp instances * refactor(linear_algebra/lc): use families instead of sets * refactor(linear_algebra/lc): remove set argument in lin_indep * refactor(linear_algebra/lc): clean up * refactor(linear_algebra/lc): more clean up * refactor(linear_algebra/lc): set_option in section * refactor(linear_algebra/lc): decidability proof * refactor(linear_algebra/lc): arrow precedence * refactor(linear_algebra/lc): more cleanup * make data.finsupp classical * trouble with data/polynomial * ... * more classical * merge * merge * merge * fix * removing more * minor * ? * progress, using convert * working? * remove some unnecessary converts * fixes * err * oops * various * various * fix free_comm_ring * remove test lines * fix linear_algebra/matrix.lean * Fix errors in power_series.lean * trying to turn instances back on * restore some instances * no joy * fix mv_polynomial errors * another convert
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on Zulip, this PR makes
data/finsupp,data/polynomialanddata/mv_polynomialclassical.