Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

interface-dht and kad-dht QueryEvents type #409

Closed
#410
Closed
interface-dht and kad-dht QueryEvents type#409
#410
@tabcat

Description

@tabcat
tabcat
opened on Jun 2, 2023

The exported QueryEvents type from @libp2p/interfaces-dht and @libp2p/kad-dht are not equal.

interface-dht:

js-libp2p-interfaces/packages/interface-dht/src/index.ts

Line 129 in 9e86d57

export type QueryEvent = SendingQueryEvent | PeerResponseEvent | FinalPeerEvent | QueryErrorEvent | ProviderEvent | ValueEvent | AddingPeerEvent | DialingPeerEvent

kad-dht:
https://github.com/libp2p/js-libp2p-kad-dht/blame/2af3a0cad4e718b6bdf3b4a9b114d9f4b4860653/src/index.ts#L149

divergence stems from change in kad-dht https://github.com/libp2p/js-libp2p-kad-dht/pull/472/files

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions