user-facing config of max request/response message size

[maqi]

As of the merged PR #5792, the underlying CBOR and JSON codecs do expose set_request_size_maximum and set_response_size_maximum methods.

However, those codecs live in private modules (protocols/request-response/src/cbor.rs) and are not publicly re-exported.
That means, out of the box, user cannot import the codec type to call these setters

Shall a user-facing config of max_request/response_message_size to be added and links to the codecs during construction ?
for a more covenient usage.

[elenaf9]

The cbor and json modules have been made public with #5830. It's just not released yet.
@maqi is this something that you need? We can try to cut a new release soon (cc @jxs).

[maqi]

The cbor and json modules have been made public with #5830

Ah, right, now I understand why Chat-GPT keeps suggesting the following approach to create a bespoken codec :

use libp2p::request_response::cbor::{Codec as CborCodec, Behaviour as CborBehaviour};

// 2. Create and configure the CBOR codec:
let mut codec = CborCodec::<MyRequest, MyResponse>::default();

// bump the maximum request size to 4 MiB:
codec.set_request_size_maximum(4 * 1024 * 1024);
 
// 3. Build the request-response behaviour using `with_codec`:
let rr_behaviour = CborBehaviour::with_codec(codec, protocols, cfg);

instead of using the default:

request_response::cbor::Behaviour::new(proto, cfg)

but the released 0.55.0 (that I am working on) keeps saying cbor is private.

The bespoken codec approach does allow the request_response max_size can be set.
But if it can be done via the user-facing behaviour config, it will be more convenient to use.

We can try to cut a new release soon

Oh, that will be excellent, thx a lot !
Really looking forward to it !

[maqi]

Hi, @elenaf9 and @jxs

Any idea when a release will be published ?
We need this configurable codec feature to lift up the max_request_size bit urgent.
Thx.

[dariusc93]

Hi, @elenaf9 and @jxs

Any idea when a release will be published ? We need this configurable codec feature to lift up the max_request_size bit urgent. Thx.

Until it is published, is it possible for you to fork the codec to use it instead so you can utilize the functions to set the max request size?

[jxs]

Hi @maqi we plan to do it after merging the async-std deprecation PR'. Meanwhile does Darius suggestions work for you?

[maqi]

yeah we are going to do the fork.
just wondering if there is any schedule of the next libp2p release. : )