LPS-135470 Use StringBundler.concat

Author: brianchandotcom

portal-impl/src/com/liferay/portal/events/ServicePreAction.java

@@ -835,22 +835,16 @@ private ThemeDisplay _initThemeDisplay(
 
 		// Company logo
 
-		StringBundler sb = new StringBundler(6);
-
-		sb.append(imagePath);
-		sb.append("/company_logo");
+		String companyLogo = imagePath + "/company_logo";
 
 		long companyLogoId = company.getLogoId();
 
 		if (companyLogoId > 0) {
-			sb.append("?img_id=");
-			sb.append(company.getLogoId());
-			sb.append("&t=");
-			sb.append(WebServerServletTokenUtil.getToken(company.getLogoId()));
+			companyLogo = StringBundler.concat(
+				"?img_id=", company.getLogoId(), "&t=",
+				WebServerServletTokenUtil.getToken(company.getLogoId()));
 		}
 
-		String companyLogo = sb.toString();
-
 		int companyLogoHeight = 0;
 		int companyLogoWidth = 0;
 
@@ -1020,19 +1014,16 @@ private ThemeDisplay _initThemeDisplay(
 						!GroupPermissionUtil.contains(
 							permissionChecker, sourceGroup, ActionKeys.VIEW)) {
 
-						sb = new StringBundler(6);
-
-						sb.append("User ");
-						sb.append(user.getUserId());
-						sb.append(" is not allowed to access the private ");
-						sb.append("pages of user ");
-						sb.append(sourceGroup.getClassPK());
+						String message = StringBundler.concat(
+							"User ", user.getUserId(),
+							" is not allowed to access the private pages of ",
+							"user ", sourceGroup.getClassPK());
 
 						if (_log.isWarnEnabled()) {
-							_log.warn(sb.toString());
+							_log.warn(message);
 						}
 
-						throw new NoSuchLayoutException(sb.toString());
+						throw new NoSuchLayoutException(message);
 					}
 
 					layout = new VirtualLayout(layout, sourceGroup);
@@ -1109,20 +1100,16 @@ else if (!loginRequest &&
 						user.getUserId());
 				}
 
-				sb = new StringBundler(6);
-
-				sb.append("User ");
-				sb.append(user.getUserId());
-				sb.append(" is not allowed to access the ");
-				sb.append(layout.isPrivateLayout() ? "private" : "public");
-				sb.append(" pages of group ");
-				sb.append(layout.getGroupId());
+				String message = StringBundler.concat(
+					"User ", user.getUserId(), " is not allowed to access the ",
+					layout.isPrivateLayout() ? "private" : "public",
+					" pages of group ", layout.getGroupId());
 
 				if (_log.isWarnEnabled()) {
-					_log.warn(sb.toString());
+					_log.warn(message);
 				}
 
-				throw new NoSuchLayoutException(sb.toString());
+				throw new NoSuchLayoutException(message);
 			}
 			else if (loginRequest && !viewableGroup) {
 				layout = null;
@@ -1231,15 +1218,9 @@ else if (group.isLayoutPrototype()) {
 				}
 
 				if (logoId > 0) {
-					sb = new StringBundler(5);
-
-					sb.append(imagePath);
-					sb.append("/layout_set_logo?img_id=");
-					sb.append(logoId);
-					sb.append("&t=");
-					sb.append(WebServerServletTokenUtil.getToken(logoId));
-
-					layoutSetLogo = sb.toString();
+					layoutSetLogo = StringBundler.concat(
+						imagePath, "/layout_set_logo?img_id=", logoId, "&t=",
+						WebServerServletTokenUtil.getToken(logoId));
 
 					Image layoutSetLogoImage =
 						ImageLocalServiceUtil.getCompanyLogo(logoId);