Skip to content

Commit e246186

Browse files
committed
chore(http/retry): add todo comments concerning eos
for now, a replaying body that will not yield trailers must be polled to the `None` before reporting itself as reaching the end of the stream. this isn't hugely important, but does affect some test control flow. leave two todo comments so that if/when upgrading to hyper 1.0, it is clear that these are not load-bearing or otherwise expected behavior, should this behavior be rectified. Signed-off-by: katelyn martin <[email protected]>
1 parent b4b1e5c commit e246186

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

linkerd/http/retry/src/replay/tests.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,7 @@ async fn eos_only_when_fully_replayed() {
358358
.expect("yields a frame")
359359
.into_data()
360360
.expect("yields a data frame");
361+
// TODO(kate): the replay doesn't report ending until it has (not) yielded trailers.
361362
assert!(replay.frame().await.is_none());
362363
assert!(replay.is_end_stream());
363364

@@ -378,6 +379,7 @@ async fn eos_only_when_fully_replayed() {
378379
.expect("yields a frame")
379380
.into_data()
380381
.expect("yields a data frame");
382+
// TODO(kate): the replay doesn't report ending until it has (not) yielded trailers.
381383
assert!(replay2.frame().await.is_none());
382384
assert!(replay2.is_end_stream());
383385
}

0 commit comments

Comments
 (0)