Skip to content

Commit dc1a79a

Browse files
committed
MC: Make save-temp-labels imply UseNamesOnTempLabels
UseNamesOnTempLabels was false in MCObjectStreamer. `createTempSymbol` created symbols were unnamed, making debugging difficult.
1 parent b54337d commit dc1a79a

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

llvm/lib/MC/MCContext.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ MCContext::MCContext(const Triple &TheTriple, const MCAsmInfo *mai,
7575
CurrentDwarfLoc(0, 0, 0, DWARF2_FLAG_IS_STMT, 0, 0),
7676
AutoReset(DoAutoReset), TargetOptions(TargetOpts) {
7777
SaveTempLabels = TargetOptions && TargetOptions->MCSaveTempLabels;
78+
if (SaveTempLabels)
79+
setUseNamesOnTempLabels(true);
7880
SecureLogFile = TargetOptions ? TargetOptions->AsSecureLogFile : "";
7981

8082
if (SrcMgr && SrcMgr->getNumBuffers())

llvm/test/MC/ELF/mc-dump.s

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,17 @@
2727
# CHECK-NEXT:5 LEB Value:.Ltmp0-_start Signed:0
2828
# CHECK-NEXT:]
2929

30+
# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t -debug-only=mc-dump -save-temp-labels -g 2>&1 | FileCheck %s --check-prefix=CHECK2
31+
32+
# CHECK2:5 Data Size:16 [48,8b,04,25,00,00,00,00,48,8b,04,25,00,00,00,00]
33+
# CHECK2-NEXT: Fixup @4 Value:f0@<variant 11> Kind:4021
34+
# CHECK2-NEXT: Fixup @12 Value:_start@<variant 11> Kind:4021
35+
# CHECK2-NEXT: Symbol @16 .Ltmp1
36+
# CHECK2-NEXT: Symbol @0 .Ltmp3 Temporary
37+
# CHECK2-NEXT: Symbol @8 .Ltmp4 Temporary
38+
# CHECK2-NEXT: Symbol @16 .Ltmp5 Temporary
39+
# CHECK2-NEXT: Symbol @16 .Lsec_end0 Temporary
40+
3041
_start:
3142
var = _start
3243
.org 3

0 commit comments

Comments
 (0)