apply ellipsis suggestion, test for exceptions

Author: dinmukhamedm

src/lmnr/opentelemetry_lib/decorators/__init__.py

@@ -20,6 +20,9 @@
 )
 from lmnr.opentelemetry_lib.tracing import TracerWrapper
 from lmnr.opentelemetry_lib.utils.json_encoder import JSONEncoder
+from lmnr.sdk.log import get_default_logger
+
+logger = get_default_logger(__name__)
 
 
 class CustomJSONEncoder(JSONEncoder):
@@ -91,7 +94,8 @@ def _process_input(
             span.set_attribute(SPAN_INPUT, "Laminar: input too large to record")
         else:
             span.set_attribute(SPAN_INPUT, inp)
-    except TypeError:
+    except Exception:
+        logger.debug("Failed to process input, ignoring", exc_info=True)
         pass
 
 
@@ -117,7 +121,8 @@ def _process_output(
             span.set_attribute(SPAN_OUTPUT, "Laminar: output too large to record")
         else:
             span.set_attribute(SPAN_OUTPUT, output)
-    except TypeError:
+    except Exception:
+        logger.debug("Failed to process output, ignoring", exc_info=True)
         pass
 
 

tests/test_observe.py

@@ -299,6 +299,24 @@ def observed_foo(x):
     assert json.loads(spans[0].attributes["lmnr.span.input"]) == {"x": 2}
 
 
+def test_observe_input_formatter_exception(exporter: InMemorySpanExporter):
+    def input_formatter(x):
+        raise ValueError("test")
+
+    @observe(input_formatter=input_formatter)
+    def observed_foo(x):
+        return x
+
+    result = observed_foo(1)
+    spans = exporter.get_finished_spans()
+    assert result == 1
+    assert len(spans) == 1
+    assert spans[0].name == "observed_foo"
+    assert spans[0].attributes["lmnr.span.instrumentation_source"] == "python"
+    assert spans[0].attributes["lmnr.span.path"] == ("observed_foo",)
+    assert "lmnr.span.input" not in spans[0].attributes
+
+
 def test_observe_input_formatter_with_kwargs(exporter: InMemorySpanExporter):
     def input_formatter(x, **kwargs):
         return {"x": x + 1, "custom-A": f"{kwargs.get('a')}--"}
@@ -369,6 +387,21 @@ def observed_foo(x):
     assert json.loads(spans[0].attributes["lmnr.span.output"]) == {"x": 2}
 
 
+def test_observe_output_formatter_exception(exporter: InMemorySpanExporter):
+    def output_formatter(x):
+        raise ValueError("test")
+
+    @observe(output_formatter=output_formatter)
+    def observed_foo(x):
+        return x
+
+    result = observed_foo(1)
+    spans = exporter.get_finished_spans()
+    assert result == 1
+    assert len(spans) == 1
+    assert "lmnr.span.output" not in spans[0].attributes
+
+
 @pytest.mark.asyncio
 async def test_observe_output_formatter_async(exporter: InMemorySpanExporter):
     def output_formatter(x):