fix: only non-iterable, non-Date objects, regardless of prototype are valid for Object type (#383)

vtsio87 · web-flow · commit ab227a3f6926 · 2020-07-16T10:26:56.000-05:00
diff --git a/package/lib/validation/typeValidator/index.js b/package/lib/validation/typeValidator/index.js
@@ -24,7 +24,7 @@ export default function typeValidator() {
 
   if (expectedType === Object || SimpleSchema.isSimpleSchema(expectedType)) {
     // Is it an object?
-    if (Object.prototype.toString.call(keyValue) === '[object Object]') return;
+    if (keyValue === Object(keyValue) && typeof keyValue[Symbol.iterator] !== 'function' && !(keyValue instanceof Date)) return;
     return { type: SimpleSchema.ErrorTypes.EXPECTED_TYPE, dataType: 'Object' };
   }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ export default function typeValidator() {`
`24`	`24`
`25`	`25`	`if (expectedType === Object \|\| SimpleSchema.isSimpleSchema(expectedType)) {`
`26`	`26`	`// Is it an object?`
`27`		`- if (Object.prototype.toString.call(keyValue) === '[object Object]') return;`
	`27`	`+ if (keyValue === Object(keyValue) && typeof keyValue[Symbol.iterator] !== 'function' && !(keyValue instanceof Date)) return;`
`28`	`28`	`return { type: SimpleSchema.ErrorTypes.EXPECTED_TYPE, dataType: 'Object' };`
`29`	`29`	`}`
`30`	`30`