Skip to content

Fix nav default order#655

Merged
oscarotero merged 4 commits into
lumeland:mainfrom
dogfuntom:fix-nav-default-order
Aug 18, 2024
Merged

Fix nav default order#655
oscarotero merged 4 commits into
lumeland:mainfrom
dogfuntom:fix-nav-default-order

Conversation

@dogfuntom
Copy link
Copy Markdown
Contributor

Description

Nav plugin was ignoring the default order for the children option passed during its import/installation.

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@dogfuntom
Copy link
Copy Markdown
Contributor Author

However, the nav.tests now fail because of some kind of newline (dis)appearance between </html> and ',.

@dogfuntom dogfuntom marked this pull request as ready for review August 15, 2024 14:26
Comment thread tests/assets/nav/_includes/main.vto
@oscarotero oscarotero merged commit 8f6a479 into lumeland:main Aug 18, 2024
@oscarotero
Copy link
Copy Markdown
Member

Thank you!

@dogfuntom dogfuntom deleted the fix-nav-default-order branch August 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants