esbuild plugin: add proper support for lume url rewrites#685
Merged
oscarotero merged 1 commit intoNov 4, 2024
Conversation
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
4 times, most recently
from
53af308 to
c1a9c99
Compare
into-the-v0id
added a commit
to into-the-v0id/lume
that referenced
this pull request
Nov 1, 2024
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
from
c1a9c99 to
d4bb414
Compare
into-the-v0id
added a commit
to into-the-v0id/lume
that referenced
this pull request
Nov 1, 2024
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
from
d4bb414 to
4e406c4
Compare
into-the-v0id
added a commit
to into-the-v0id/lume
that referenced
this pull request
Nov 1, 2024
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
from
4e406c4 to
0609c79
Compare
into-the-v0id
added a commit
to into-the-v0id/lume
that referenced
this pull request
Nov 1, 2024
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
from
0609c79 to
0792ac6
Compare
oscarotero
requested changes
Nov 1, 2024
Member
oscarotero
left a comment
oscarotero
left a comment
There was a problem hiding this comment.
That's a great approach!
I just left a comment becasue I don't think we need to create a new util function for this.
Early next week I'll review it more in depth and will merge it.
Thanks!
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
from
2cb5d61 to
0792ac6
Compare
into-the-v0id
added a commit
to into-the-v0id/lume
that referenced
this pull request
Nov 4, 2024
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
from
78bc9a0 to
460142d
Compare
into-the-v0id
force-pushed
the
feature/esbuild-url-rewrite
branch
from
460142d to
f7cfd43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a follow up of PR #678. It's actually possible to pass esbuild a in/out path map as
entryPoints. Esbuild will then rewrite the urls accodingly. I initially thought using that would disable/breakentryNamesbut that is not the case. This allows us to get full support for lume url rewrites (basenameandurl) for esbuild.This PR also extends that to the manual url rewriting done by lume when bundling via esbuild is disabled. And extends manual import rewriting to dynamic imports and standalone imports without a
from.Related Issues
Related to #678
Check List
CODE OF CONDUCT
CONTRIBUTING
send multiple pull request.
fmtto fix the code format before commit.CHANGELOG.md.