Skip to content

Commit ef05f04

Browse files
zentolzentol
committed
[hotfix][build] Clarify purpose of build-helper-maven-plugin
1 parent 4e860b6 commit ef05f04

File tree

9 files changed

+33
-25
lines changed

9 files changed

+33
-25
lines changed

‎flink-connectors/flink-hadoop-compatibility/pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,13 @@ under the License.
167167
</configuration>
168168
</plugin>
169169

170-
<!-- Adding scala source directories to build path -->
170+
<!-- Adding scala source directories to build path
171+
This is required for the source jar -->
171172
<plugin>
172173
<groupId>org.codehaus.mojo</groupId>
173174
<artifactId>build-helper-maven-plugin</artifactId>
174175
<executions>
175-
<!-- Add src/main/scala to eclipse build path -->
176+
<!-- Add src/main/scala to build path -->
176177
<execution>
177178
<id>add-source</id>
178179
<phase>generate-sources</phase>

‎flink-end-to-end-tests/flink-end-to-end-tests-scala/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,12 +183,13 @@ under the License.
183183
</configuration>
184184
</plugin>
185185

186-
<!-- Adding scala source directories to build path -->
186+
<!-- Adding scala source directories to build path
187+
This is required for the source jar -->
187188
<plugin>
188189
<groupId>org.codehaus.mojo</groupId>
189190
<artifactId>build-helper-maven-plugin</artifactId>
190191
<executions>
191-
<!-- Add src/main/scala to eclipse build path -->
192+
<!-- Add src/main/scala to build path -->
192193
<execution>
193194
<id>add-source</id>
194195
<phase>generate-sources</phase>
@@ -201,7 +202,7 @@ under the License.
201202
</sources>
202203
</configuration>
203204
</execution>
204-
<!-- Add src/test/scala to eclipse build path -->
205+
<!-- Add src/test/scala to build path -->
205206
<execution>
206207
<id>add-test-source</id>
207208
<phase>generate-test-sources</phase>

‎flink-examples/flink-examples-batch/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,13 @@ under the License.
146146
</configuration>
147147
</plugin>
148148

149-
<!-- Adding scala source directories to build path -->
149+
<!-- Adding scala source directories to build path
150+
This is required for the source jar -->
150151
<plugin>
151152
<groupId>org.codehaus.mojo</groupId>
152153
<artifactId>build-helper-maven-plugin</artifactId>
153154
<executions>
154-
<!-- Add src/main/scala to eclipse build path -->
155+
<!-- Add src/main/scala to build path -->
155156
<execution>
156157
<id>add-source</id>
157158
<phase>generate-sources</phase>
@@ -164,7 +165,7 @@ under the License.
164165
</sources>
165166
</configuration>
166167
</execution>
167-
<!-- Add src/test/scala to eclipse build path -->
168+
<!-- Add src/test/scala to build path -->
168169
<execution>
169170
<id>add-test-source</id>
170171
<phase>generate-test-sources</phase>

‎flink-examples/flink-examples-streaming/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -457,12 +457,13 @@ under the License.
457457
</configuration>
458458
</plugin>
459459

460-
<!-- Adding scala source directories to build path -->
460+
<!-- Adding scala source directories to build path
461+
This is required for the source jar -->
461462
<plugin>
462463
<groupId>org.codehaus.mojo</groupId>
463464
<artifactId>build-helper-maven-plugin</artifactId>
464465
<executions>
465-
<!-- Add src/main/scala to eclipse build path -->
466+
<!-- Add src/main/scala to build path -->
466467
<execution>
467468
<id>add-source</id>
468469
<phase>generate-sources</phase>
@@ -475,7 +476,7 @@ under the License.
475476
</sources>
476477
</configuration>
477478
</execution>
478-
<!-- Add src/test/scala to eclipse build path -->
479+
<!-- Add src/test/scala to build path -->
479480
<execution>
480481
<id>add-test-source</id>
481482
<phase>generate-test-sources</phase>

‎flink-libraries/flink-cep-scala/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ under the License.
144144
<groupId>org.codehaus.mojo</groupId>
145145
<artifactId>build-helper-maven-plugin</artifactId>
146146
<executions>
147-
<!-- Add src/main/scala to eclipse build path -->
147+
<!-- Add src/main/scala to build path -->
148148
<execution>
149149
<id>add-source</id>
150150
<phase>generate-sources</phase>
@@ -157,7 +157,7 @@ under the License.
157157
</sources>
158158
</configuration>
159159
</execution>
160-
<!-- Add src/test/scala to eclipse build path -->
160+
<!-- Add src/test/scala to build path -->
161161
<execution>
162162
<id>add-test-source</id>
163163
<phase>generate-test-sources</phase>

‎flink-scala/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,13 @@ under the License.
227227
</configuration>
228228
</plugin>
229229

230-
<!-- Adding scala source directories to build path -->
230+
<!-- Adding scala source directories to build path
231+
This is required for the source jar -->
231232
<plugin>
232233
<groupId>org.codehaus.mojo</groupId>
233234
<artifactId>build-helper-maven-plugin</artifactId>
234235
<executions>
235-
<!-- Add src/main/scala to eclipse build path -->
236+
<!-- Add src/main/scala to build path -->
236237
<execution>
237238
<id>add-source</id>
238239
<phase>generate-sources</phase>
@@ -245,7 +246,7 @@ under the License.
245246
</sources>
246247
</configuration>
247248
</execution>
248-
<!-- Add src/test/scala to eclipse build path -->
249+
<!-- Add src/test/scala to build path -->
249250
<execution>
250251
<id>add-test-source</id>
251252
<phase>generate-test-sources</phase>

‎flink-streaming-scala/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,12 +220,13 @@ under the License.
220220
</configuration>
221221
</plugin>
222222

223-
<!-- Adding scala source directories to build path -->
223+
<!-- Adding scala source directories to build path
224+
This is required for the source jar -->
224225
<plugin>
225226
<groupId>org.codehaus.mojo</groupId>
226227
<artifactId>build-helper-maven-plugin</artifactId>
227228
<executions>
228-
<!-- Add src/main/scala to eclipse build path -->
229+
<!-- Add src/main/scala to build path -->
229230
<execution>
230231
<id>add-source</id>
231232
<phase>generate-sources</phase>
@@ -238,7 +239,7 @@ under the License.
238239
</sources>
239240
</configuration>
240241
</execution>
241-
<!-- Add src/test/scala to eclipse build path -->
242+
<!-- Add src/test/scala to build path -->
242243
<execution>
243244
<id>add-test-source</id>
244245
<phase>generate-test-sources</phase>

‎flink-tests/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,12 +372,13 @@ under the License.
372372
</configuration>
373373
</plugin>
374374

375-
<!-- Adding scala source directories to build path -->
375+
<!-- Adding scala source directories to build path
376+
This is required for the source jar -->
376377
<plugin>
377378
<groupId>org.codehaus.mojo</groupId>
378379
<artifactId>build-helper-maven-plugin</artifactId>
379380
<executions>
380-
<!-- Add src/main/scala to eclipse build path -->
381+
<!-- Add src/main/scala to build path -->
381382
<execution>
382383
<id>add-source</id>
383384
<phase>generate-sources</phase>
@@ -390,7 +391,7 @@ under the License.
390391
</sources>
391392
</configuration>
392393
</execution>
393-
<!-- Add src/test/scala to eclipse build path -->
394+
<!-- Add src/test/scala to build path -->
394395
<execution>
395396
<id>add-test-source</id>
396397
<phase>generate-test-sources</phase>

‎flink-yarn-tests/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,12 +315,13 @@ under the License.
315315
</configuration>
316316
</plugin>
317317

318-
<!-- Adding scala source directories to build path -->
318+
<!-- Adding scala source directories to build path
319+
This is required for the source jar -->
319320
<plugin>
320321
<groupId>org.codehaus.mojo</groupId>
321322
<artifactId>build-helper-maven-plugin</artifactId>
322323
<executions>
323-
<!-- Add src/main/scala to eclipse build path -->
324+
<!-- Add src/main/scala to build path -->
324325
<execution>
325326
<id>add-source</id>
326327
<phase>generate-sources</phase>
@@ -333,7 +334,7 @@ under the License.
333334
</sources>
334335
</configuration>
335336
</execution>
336-
<!-- Add src/test/scala to eclipse build path -->
337+
<!-- Add src/test/scala to build path -->
337338
<execution>
338339
<id>add-test-source</id>
339340
<phase>generate-test-sources</phase>

0 commit comments

Comments
 (0)