🌱 Bump OSV scanner action to fix SARIF upload#2694
Conversation
metal3-io-bot
added
the
size/XS
lentzi90
force-pushed
the
lentzi90/osv-scanner-bump
branch
from
4063a8b to
690a76e
Compare
lentzi90
changed the title
This version includes a fix for the issue with uploading the SARIF file (it is missing results). This commit also makes the workflow run on PRs that touch the workflow file. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
lentzi90
force-pushed
the
lentzi90/osv-scanner-bump
branch
from
690a76e to
0897da9
Compare
metal3-io-bot
added
size/S
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
/approve
Let's do the same fix for IPAM/BMO/IRSO as well where we have 2.1.0 bumped.
metal3-io-bot
added
the
approved
| osv-scanner) | ||
| version=$("${OSVSCANNER_CMD[@]}" -v | grep version | cut -f3 -d" ") | ||
| min_version="2.1.0" | ||
| min_version="2.2.0" |
There was a problem hiding this comment.
Perhaps not strictly needed since the issue was only abut uploading the results, but I included it anyway
There was a problem hiding this comment.
I was thinking the same, but as 2.1.0 has issues producing results, it is not bad idea to have 2.2.0 as minimum.
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @kashifest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
What this PR does / why we need it:
This version includes a fix for the issue with uploading the SARIF file (it is missing results). (google/osv-scanner#2064 Fix SARIF v3 output to include results.)
This commit also makes the workflow run on PRs that touch the workflow file.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #