Skip to content

Extension details view should show extension contributions #10366

Closed
@kieferrm

Description

@kieferrm
Member

Extensions can contribute commands to the command palette, editor menus, and the explorer context menu. In addition, commands can be bound to keyboard shortcuts.

The extension details view should give users a way to better understand the contributions an extensions makes and if those contributions cause conflicts with core VS Code keyboard shortcuts or with keyboard shortcuts used by other installed extensions.

Activity

added
plan-itemVS Code - planned item for upcoming
extensionsIssues concerning extensions
on Aug 9, 2016
added this to the August 2016 milestone on Aug 9, 2016
joaomoreno

joaomoreno commented on Aug 15, 2016

@joaomoreno
Member
  • configuration - Display a list of the config property names.
    commands - Display a list of the command ids.
    menus - Show a table of the menu labels and context associated with the commands. Maybe combine with the commands table.
    keybindings - Show a table of the keybindings associated with the commands. Maybe combine with the commands table.
    languages - Show a table of language ids and file extensions.
    debuggers - Show a list of the debuggers' labels.
    grammars - Maybe combine with the languages table?
    themes - Show a list of the themes' names.
    snippets - Show whether a language has snippets or not. Maybe combine with the languages table.
    jsonValidation - Show a list of file matches.
joaomoreno

joaomoreno commented on Aug 15, 2016

@joaomoreno
Member

Maybe each section can be implemented...

using...

the details tag!

joaomoreno

joaomoreno commented on Aug 25, 2016

@joaomoreno
Member

Displaying of contributions is ✅ .

cc @egamma @kieferrm

Conflicts are much harder. While an extension provides a keybinding with a given context, I can't unequivocally say that it will or won't conflict with another existing keybinding that has a different context. The same keybinding might come from two extensions and act in mutually exclusive contexts, thus never conflicting.

Unless there's something @alexandrudima knows and I don't, I suggest to push the conflicts out of this plan item.

alexdima

alexdima commented on Aug 26, 2016

@alexdima
Member

I have a mini "SMT solver" in there, that's why I kept the language constrained to have only &&. I can prove if one keybinding item absolutely overwrites another keybinding item.

https://github.com/Microsoft/vscode/blob/a3493c75934a67ddadff71818ab8f7201eeb0fbf/src/vs/platform/keybinding/common/keybindingResolver.ts#L205

joaomoreno

joaomoreno commented on Aug 26, 2016

@joaomoreno
Member

Pretty cool, I'll give it a try.

joaomoreno

joaomoreno commented on Aug 26, 2016

@joaomoreno
Member

@alexandrudima Any pointers on how to get a hold of all registered keybindings along with their configured when clause?

joaomoreno

joaomoreno commented on Aug 29, 2016

@joaomoreno
Member

Decided to remove the conflicts out of this plan item.

locked and limited conversation to collaborators on Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

extensionsIssues concerning extensionsfeature-requestRequest for new features or functionalityplan-itemVS Code - planned item for upcoming

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @joaomoreno@kieferrm@alexdima

      Issue actions

        Extension details view should show extension contributions · Issue #10366 · microsoft/vscode