modules: Port bitcoin-core/secp256k1#1815 to zkp-specific code

Author: mllwchrry

src/modules/bppp/main_impl.h

@@ -23,11 +23,11 @@ secp256k1_bppp_generators *secp256k1_bppp_generators_create(const secp256k1_cont
 
     VERIFY_CHECK(ctx != NULL);
 
-    ret = (secp256k1_bppp_generators *)checked_malloc(&ctx->error_callback, sizeof(*ret));
+    ret = checked_malloc(&ctx->error_callback, sizeof(*ret));
     if (ret == NULL) {
         return NULL;
     }
-    ret->gens = (secp256k1_ge*)checked_malloc(&ctx->error_callback, n * sizeof(*ret->gens));
+    ret->gens = checked_malloc(&ctx->error_callback, n * sizeof(*ret->gens));
     if (ret->gens == NULL) {
         free(ret);
         return NULL;
@@ -60,12 +60,12 @@ secp256k1_bppp_generators* secp256k1_bppp_generators_parse(const secp256k1_conte
         return NULL;
     }
 
-    ret = (secp256k1_bppp_generators *)checked_malloc(&ctx->error_callback, sizeof(*ret));
+    ret = checked_malloc(&ctx->error_callback, sizeof(*ret));
     if (ret == NULL) {
         return NULL;
     }
     ret->n = n;
-    ret->gens = (secp256k1_ge*)checked_malloc(&ctx->error_callback, n * sizeof(*ret->gens));
+    ret->gens = checked_malloc(&ctx->error_callback, n * sizeof(*ret->gens));
     if (ret->gens == NULL) {
         free(ret);
         return NULL;

src/modules/bppp/tests_impl.h

@@ -514,12 +514,12 @@ secp256k1_bppp_generators* bppp_generators_parse_regular(const unsigned char* da
         return NULL;
     }
 
-    ret = (secp256k1_bppp_generators *)checked_malloc(&CTX->error_callback, sizeof(*ret));
+    ret = checked_malloc(&CTX->error_callback, sizeof(*ret));
     if (ret == NULL) {
         return NULL;
     }
     ret->n = n;
-    ret->gens = (secp256k1_ge*)checked_malloc(&CTX->error_callback, n * sizeof(*ret->gens));
+    ret->gens = checked_malloc(&CTX->error_callback, n * sizeof(*ret->gens));
     if (ret->gens == NULL) {
         free(ret);
         return NULL;

src/modules/rangeproof/tests_impl.h

@@ -544,8 +544,8 @@ static void test_multiple_generators(void) {
     secp256k1_scalar_get_b32(generator_seed, &s);
     /* Create all the needed generators */
     for (i = 0; i < n_generators; i++) {
-        generator_blind[i] = (unsigned char*) malloc(32);
-        pedersen_blind[i] = (unsigned char*) malloc(32);
+        generator_blind[i] = malloc(32);
+        pedersen_blind[i] = malloc(32);
 
         testutil_random_scalar_order(&s);
         secp256k1_scalar_get_b32(generator_blind[i], &s);

src/modules/surjection/main_impl.h

@@ -182,7 +182,7 @@ int secp256k1_surjectionproof_allocate_initialized(const secp256k1_context* ctx,
     ARG_CHECK(proof_out_p != NULL);
     *proof_out_p = 0;
 
-    proof = (secp256k1_surjectionproof*)checked_malloc(&ctx->error_callback, sizeof(secp256k1_surjectionproof));
+    proof = checked_malloc(&ctx->error_callback, sizeof(secp256k1_surjectionproof));
     if (proof != NULL) {
         ret = secp256k1_surjectionproof_initialize(ctx, proof, input_index, fixed_input_tags, n_input_tags, n_input_tags_to_use, fixed_output_tag, n_max_iterations, random_seed32);
         if (ret) {

src/modules/whitelist/tests_impl.h

@@ -43,10 +43,10 @@ static void test_whitelist_end_to_end_internal(const unsigned char *summed_secke
 }
 
 static void test_whitelist_end_to_end(const size_t n_keys, int test_all_keys) {
-    unsigned char **online_seckey = (unsigned char **) malloc(n_keys * sizeof(*online_seckey));
-    unsigned char **summed_seckey = (unsigned char **) malloc(n_keys * sizeof(*summed_seckey));
-    secp256k1_pubkey *online_pubkeys = (secp256k1_pubkey *) malloc(n_keys * sizeof(*online_pubkeys));
-    secp256k1_pubkey *offline_pubkeys = (secp256k1_pubkey *) malloc(n_keys * sizeof(*offline_pubkeys));
+    unsigned char **online_seckey = malloc(n_keys * sizeof(*online_seckey));
+    unsigned char **summed_seckey = malloc(n_keys * sizeof(*summed_seckey));
+    secp256k1_pubkey *online_pubkeys = malloc(n_keys * sizeof(*online_pubkeys));
+    secp256k1_pubkey *offline_pubkeys = malloc(n_keys * sizeof(*offline_pubkeys));
 
     secp256k1_scalar ssub;
     unsigned char csub[32];
@@ -63,8 +63,8 @@ static void test_whitelist_end_to_end(const size_t n_keys, int test_all_keys) {
     for (i = 0; i < n_keys; i++) {
         secp256k1_scalar son, soff;
 
-        online_seckey[i] = (unsigned char *) malloc(32);
-        summed_seckey[i] = (unsigned char *) malloc(32);
+        online_seckey[i] = malloc(32);
+        summed_seckey[i] = malloc(32);
 
         /* Create two keys */
         testutil_random_scalar_order_test(&son);