refactor: remove ret from secp256k1_ec_pubkey_serialize

kevkevinpal · kevkevinpal · commit 3daab83a6050 · 2025-12-09T16:08:35.000-05:00
diff --git a/src/secp256k1.c b/src/secp256k1.c
@@ -268,7 +268,6 @@ int secp256k1_ec_pubkey_parse(const secp256k1_context* ctx, secp256k1_pubkey* pu
 int secp256k1_ec_pubkey_serialize(const secp256k1_context* ctx, unsigned char *output, size_t *outputlen, const secp256k1_pubkey* pubkey, unsigned int flags) {
     secp256k1_ge Q;
     size_t len;
-    int ret = 0;
 
     VERIFY_CHECK(ctx != NULL);
     ARG_CHECK(outputlen != NULL);
@@ -287,9 +286,9 @@ int secp256k1_ec_pubkey_serialize(const secp256k1_context* ctx, unsigned char *o
             secp256k1_eckey_pubkey_serialize65(&Q, output);
             *outputlen = 65;
         }
-        ret = 1;
+        return 1;
     }
-    return ret;
+    return 0;
 }
 
 int secp256k1_ec_pubkey_cmp(const secp256k1_context* ctx, const secp256k1_pubkey* pubkey0, const secp256k1_pubkey* pubkey1) {

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,6 @@ int secp256k1_ec_pubkey_parse(const secp256k1_context* ctx, secp256k1_pubkey* pu`
`268`	`268`	`int secp256k1_ec_pubkey_serialize(const secp256k1_context* ctx, unsigned char output, size_t outputlen, const secp256k1_pubkey* pubkey, unsigned int flags) {`
`269`	`269`	`secp256k1_ge Q;`
`270`	`270`	`size_t len;`
`271`		`- int ret = 0;`
`272`	`271`
`273`	`272`	`VERIFY_CHECK(ctx != NULL);`
`274`	`273`	`ARG_CHECK(outputlen != NULL);`
`@@ -287,9 +286,9 @@ int secp256k1_ec_pubkey_serialize(const secp256k1_context* ctx, unsigned char *o`
`287`	`286`	`secp256k1_eckey_pubkey_serialize65(&Q, output);`
`288`	`287`	`*outputlen = 65;`
`289`	`288`	`}`
`290`		`- ret = 1;`
	`289`	`+ return 1;`
`291`	`290`	`}`
`292`		`- return ret;`
	`291`	`+ return 0;`
`293`	`292`	`}`
`294`	`293`
`295`	`294`	`int secp256k1_ec_pubkey_cmp(const secp256k1_context* ctx, const secp256k1_pubkey* pubkey0, const secp256k1_pubkey* pubkey1) {`