Skip to content

Commit 5574738

Browse files
Copilotmark-wiemer
andauthored
fix: use semver dot separator for beta pre-release versions (beta-X → beta.X) (#5764)
Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mark Wiemer <markwiemer@outlook.com>
1 parent ec0fe0d commit 5574738

File tree

5 files changed

+30
-8
lines changed

5 files changed

+30
-8
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{".":"12.0.0-beta-10"}
1+
{".":"12.0.0-beta.10"}

.github/workflows/mocha.yml

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,29 @@ on:
44
push:
55
branches:
66
- main
7-
paths-ignore: ["*.md", "docs/**", "docs-next/**", ".github/**", ".prettierignore", "AUTHORS", "LICENSE"]
7+
paths-ignore:
8+
[
9+
"*.md",
10+
"docs/**",
11+
"docs-next/**",
12+
".github/**",
13+
".prettierignore",
14+
"AUTHORS",
15+
"LICENSE",
16+
]
817
pull_request:
918
branches:
1019
- main
11-
paths-ignore: ["*.md", "docs/**", "docs-next/**", ".github/**", ".prettierignore", "AUTHORS", "LICENSE"]
20+
paths-ignore:
21+
[
22+
"*.md",
23+
"docs/**",
24+
"docs-next/**",
25+
".github/**",
26+
".prettierignore",
27+
"AUTHORS",
28+
"LICENSE",
29+
]
1230
types: [opened, synchronize, reopened, edited]
1331
workflow_dispatch:
1432

MAINTAINERS.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -421,12 +421,16 @@ For large releases, we recommend betas, then release candidates (RCs), then a fu
421421
Betas are when most features are available, but more will likely be added before full release.
422422
RCs are almost ready for release, but would benefit from user testing before a full release.
423423

424-
To start a new major version beta, add `Release-As: 12.0.0-beta-1` to the additional details of your PR commit message.
424+
To start a new major version beta, add `Release-As: 12.0.0-beta.1` to the additional details of your PR commit message.
425425
This must be part the last line of the commit message, not the PR description.
426426
Release Please respects this property and will update accordingly.
427427
You can also set Release Please to prelease mode to increment the beta number.
428428

429-
To transition to an RC, add `Release-As: 12.0.0-rc-1` at the end of the PR commit message.
429+
> **Important:** Always use a dot (`.`) as the separator between the pre-release label and the number (e.g. `beta.1`, not `beta-1`).
430+
> The `semver` library (used by npm) treats dot-separated numeric identifiers numerically, so `beta.10 > beta.9`.
431+
> With a dash separator, `beta-10` is a single string identifier and sorts before `beta-9` alphabetically.
432+
433+
To transition to an RC, add `Release-As: 12.0.0-rc.1` at the end of the PR commit message.
430434

431435
To transition from betas or RCs to a full release, just change Release Please back to `prerelease: false`.
432436

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "mocha",
3-
"version": "12.0.0-beta-10",
3+
"version": "12.0.0-beta.10",
44
"type": "commonjs",
55
"description": "Classic, reliable, trusted test framework for Node.js and the browser",
66
"keywords": [

0 commit comments

Comments
 (0)