Skip to content

chore: switch Suite from util.inherits to ES2015 classes#5179

Merged
mark-wiemer merged 7 commits intomochajs:mainfrom
JoshuaKGoldberg:inherits-to-class-suite
Feb 14, 2026
Merged

chore: switch Suite from util.inherits to ES2015 classes#5179
mark-wiemer merged 7 commits intomochajs:mainfrom
JoshuaKGoldberg:inherits-to-class-suite

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 20, 2024

PR Checklist

Overview

Switches Suite from the old util.extends to the snazzy new ES2015 class syntax. Very modern.

🤎

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the inherits-to-class-suite branch from 332b244 to 67104ab Compare July 20, 2024 04:22
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 20, 2024

Coverage Status

coverage: 94.314% (-0.04%) from 94.357%
when pulling 67104ab on JoshuaKGoldberg:inherits-to-class-suite
into 579e047 on mochajs:main.

@JoshuaKGoldberg
Copy link
Copy Markdown
Member Author

Closing for now since #5025 is blocked on us being ready for a next major version. We can reopen later.

@JoshuaKGoldberg
Copy link
Copy Markdown
Member Author

Reopening now that we're working on v12 (#5357).

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 98.68996% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.44%. Comparing base (15fb31a) to head (4185363).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/suite.js 98.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5179      +/-   ##
==========================================
- Coverage   88.44%   88.44%   -0.01%     
==========================================
  Files          66       66              
  Lines        4794     4793       -1     
  Branches      978      978              
==========================================
- Hits         4240     4239       -1     
  Misses        554      554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 3, 2026 14:38
Copy link
Copy Markdown
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@mark-wiemer mark-wiemer merged commit 1ce690e into mochajs:main Feb 14, 2026
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants