chore: switch Suite from util.inherits to ES2015 classes#5179
Merged
mark-wiemer merged 7 commits intomochajs:mainfrom Feb 14, 2026
Merged
chore: switch Suite from util.inherits to ES2015 classes#5179mark-wiemer merged 7 commits intomochajs:mainfrom
mark-wiemer merged 7 commits intomochajs:mainfrom
Conversation
332b244 to
67104ab
Compare
Member
Author
|
Closing for now since #5025 is blocked on us being ready for a next major version. We can reopen later. |
Member
Author
|
Reopening now that we're working on v12 (#5357). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5179 +/- ##
==========================================
- Coverage 88.44% 88.44% -0.01%
==========================================
Files 66 66
Lines 4794 4793 -1
Branches 978 978
==========================================
- Hits 4240 4239 -1
Misses 554 554 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Switches
Suitefrom the oldutil.extendsto the snazzy new ES2015classsyntax. Very modern.🤎