Make the configuration public (#1856)

Also move it to an internals namespace for other "configuration" points.

Author: mattleibow

binding/Binding.Shared/LibraryLoader.cs

@@ -2,6 +2,12 @@
 using System.IO;
 using System.Runtime.InteropServices;
 
+#if HARFBUZZ
+using HarfBuzzSharp.Internals;
+#else
+using SkiaSharp.Internals;
+#endif
+
 #if HARFBUZZ
 namespace HarfBuzzSharp
 #else

binding/Binding.Shared/PlatformConfiguration.cs

@@ -7,12 +7,12 @@
 #endif
 
 #if HARFBUZZ
-namespace HarfBuzzSharp
+namespace HarfBuzzSharp.Internals
 #else
-namespace SkiaSharp
+namespace SkiaSharp.Internals
 #endif
 {
-	internal static class PlatformConfiguration
+	public static class PlatformConfiguration
 	{
 		private const string LibCLibrary = "libc";
 

binding/Binding/GRGlInterface.cs

@@ -1,6 +1,7 @@
 using System;
 using System.ComponentModel;
 using System.Runtime.InteropServices;
+using SkiaSharp.Internals;
 
 #if __TIZEN__
 using System.Reflection;

binding/Binding/SKAutoCoInitialize.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Runtime.InteropServices;
+using SkiaSharp.Internals;
 
 namespace SkiaSharp
 {

binding/Binding/SKData.cs

@@ -2,6 +2,7 @@
 using System.IO;
 using System.Runtime.InteropServices;
 using System.Text;
+using SkiaSharp.Internals;
 
 namespace SkiaSharp
 {

binding/Binding/SKPixelSerializer.cs

@@ -1,5 +1,6 @@
 using System;
 using System.ComponentModel;
+using SkiaSharp.Internals;
 
 namespace SkiaSharp
 {

tests/Tests/ApiTests.cs

@@ -260,18 +260,5 @@ public void TestVersionsString()
 		{
 			Assert.Equal(SkiaSharpVersion.Native.ToString(2), SkiaSharpVersion.NativeString);
 		}
-
-		[Trait(CategoryKey, ApiCategory)]
-		[SkippableFact]
-		public void PlatformConfigurationIsMuslOverrideCanBeFoundViaReflection()
-		{
-			var assembly = typeof(SkiaSharpVersion).Assembly;
-			var config = assembly.DefinedTypes.FirstOrDefault(t => t.Name == "PlatformConfiguration");
-			var overrideProp = config.GetProperty("LinuxFlavor");
-
-			Assert.Equal(typeof(string), overrideProp.PropertyType);
-			Assert.True(overrideProp.CanRead);
-			Assert.True(overrideProp.CanWrite);
-		}
 	}
 }

tests/Tests/BaseTest.cs

@@ -1,5 +1,6 @@
 using System;
 using System.IO;
+using SkiaSharp.Internals;
 
 namespace SkiaSharp.Tests
 {