fix: remove unused sum[4] in LinearRegression

zhengshui · montanaflynn · commit a1c4bfa271ff · 2026-03-20T16:20:20.000-05:00
The sum[4] variable was being calculated but never used in the LinearRegression function. This removes the unnecessary computation and changes the sum array size from [5] to [4]. Fixes #85
diff --git a/regression.go b/regression.go
@@ -18,7 +18,7 @@ func LinearRegression(s Series) (regressions Series, err error) {
 	}
 
 	// Placeholder for the math to be done
-	var sum [5]float64
+	var sum [4]float64
 
 	// Loop over data keeping index in place
 	i := 0
@@ -27,7 +27,6 @@ func LinearRegression(s Series) (regressions Series, err error) {
 		sum[1] += s[i].Y
 		sum[2] += s[i].X * s[i].X
 		sum[3] += s[i].X * s[i].Y
-		sum[4] += s[i].Y * s[i].Y
 	}
 
 	// Find gradient and intercept

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func LinearRegression(s Series) (regressions Series, err error) {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`// Placeholder for the math to be done`
`21`		`- var sum [5]float64`
	`21`	`+ var sum [4]float64`
`22`	`22`
`23`	`23`	`// Loop over data keeping index in place`
`24`	`24`	`i := 0`
`@@ -27,7 +27,6 @@ func LinearRegression(s Series) (regressions Series, err error) {`
`27`	`27`	`sum[1] += s[i].Y`
`28`	`28`	`sum[2] += s[i].X * s[i].X`
`29`	`29`	`sum[3] += s[i].X * s[i].Y`
`30`		`- sum[4] += s[i].Y * s[i].Y`
`31`	`30`	`}`
`32`	`31`
`33`	`32`	`// Find gradient and intercept`